Closed
Bug 1455155
Opened 6 years ago
Closed 6 years ago
Remove AnimationValue usage in gfx/
Categories
(Core :: DOM: Animation, enhancement)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
I've written the patch for this in bug 1454324, but now I think it should be handled in a separate bug. https://treeherder.mozilla.org/#/jobs?repo=try&revision=102960fec8ea55bc24828c4cb5b7013a5a76787a
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8969158 [details] Bug 1455155 - Drop AnimationValue usage in gfx/. https://reviewboard.mozilla.org/r/237888/#review243606 ::: gfx/layers/composite/AsyncCompositionManager.cpp:14 (Diff revision 1) > #include "FrameMetrics.h" // for FrameMetrics > #include "LayerManagerComposite.h" // for LayerManagerComposite, etc > #include "Layers.h" // for Layer, ContainerLayer, etc > #include "gfxPoint.h" // for gfxPoint, gfxSize > #include "gfxPrefs.h" // for gfxPrefs > -#include "mozilla/StyleAnimationValue.h" // for StyleAnimationValue, etc > +#include "mozilla/ServoBindings.h" (Should we include a "// for ..." comment here? "for RawServoAnimationValue" ?)
Attachment #8969158 -
Flags: review?(bbirtles) → review+
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8969157 [details] Bug 1455155 - Include SystemGroup.h in platform.cpp. https://reviewboard.mozilla.org/r/237886/#review243612
Attachment #8969157 -
Flags: review?(mstange) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•6 years ago
|
||
Thank you both!
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec79f317c9d7 Include SystemGroup.h in platform.cpp. r=mstange https://hg.mozilla.org/integration/autoland/rev/64bb57f4a03a Drop AnimationValue usage in gfx/. r=birtles
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ec79f317c9d7 https://hg.mozilla.org/mozilla-central/rev/64bb57f4a03a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•