1455159 - Oculus Touch trigger touch is false in the Gamepad API until the trigger is pressed.

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[[e-mail]]

The trigger on Oculus Touch should report when it is touched (before it is pressed), but it doesn't seem to be captured by the Gamepad API as such until the trigger is pressed. 

I looked over the code that was added for button touches, but don't know what the problem is. Still, when I test it out in Firefox I don't get touched==true on the trigger until I press it down. 

"Bug" asking for button touch support: https://bugzilla.mozilla.org/show_bug.cgi?id=1336003

Button touches supported: https://reviewboard.mozilla.org/r/129924/diff/1#index_header

Oculus Touch Touch Input: https://developer.oculus.com/documentation/pcsdk/latest/concepts/dg-input-touch-touch/

Comment 1

[Daosheng Mu[:daoshengmu]]

I am going to investigate this bug.

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug-1455159-Let-Oculus-Touch-trigger-listen-touch-ev.patch

In Oculus Touch, we can use ovrTouch_LIndexTrigger or ovrTouch_LIndexPointing to listen the touch events from the trigger button. There is no touch events for the grip button from Touch currently.

Btw, sorry for I haven't setup my Mozreview yet. I will help myself on the track asap.

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1455159 - Let Oculus Touch trigger listen touch events instead of using button values;

Review commit: https://reviewboard.mozilla.org/r/246884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246884/

Comment 4

[:kip (Kearwood Gilbert)]

Comment on attachment 8980727 [details]
Bug 1455159 - Let Oculus Touch trigger listen touch events instead of using button values;

https://reviewboard.mozilla.org/r/246884/#review253004

This LGTM, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7fbb120eb12
Let Oculus Touch trigger listen touch events instead of using button values; r=kip

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b7fbb120eb12