1455166 - Lando writes an ambiguous message on successful landing

Status: RESOLVED DUPLICATE of bug 1457534

(Conduit :: Lando, defect)

Description

[Connor Sheehan [:sheehan]]

After Lando was enabled on version-control-tools I attempted to land D987. I clicked the big green "land" button and after a short period "This revision is already queued for landing with the same diff" appeared in a red box. Although the landing was successful, from a UX perspective the message and red box appear to indicate a failure and as a new user it was a little confusing. Adding to the confusion is the fact that actual error messages appear in the same box as the aforementioned warning, for example on D966 in Lando the message "This revision is not associated with a repository. In order to land, a revision must be associated with a repository on Phabricator." appears in the same red box. 

Some indication that the performed action (clicking the green land button) was successful to supplement the warning would be an improvement. Another option could be changing the colour of the box to clarify the message is a warning, or adding an icon of some sort.