Closed Bug 1455176 Opened Last year Closed Last year

PromiseTestUtils should prefer the stack in the rejection reason to the rejection stack

Categories

(Testing :: General, enhancement)

enhancement
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kmag, Assigned: kmag)

Details

Attachments

(1 file)

For thrown exceptions that propagate to the top of the event loop, the rejection stack is often just the stack for the caller which is currently spinning the event loop (in the case of xpcshell tests, some location in head.js), while the rejection reason is often an Error or Exception object with an actually useful stack. We should prefer the latter to the former.
Comment on attachment 8969144 [details]
Bug 1455176: Prefer stack from the rejection reason object to the rejection stack.

https://reviewboard.mozilla.org/r/237858/#review243610

thank you!
Attachment #8969144 - Flags: review?(aswan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/632f2133a45c3e0c0f8f342bba1596a0dae872bb
Bug 1455176: Prefer stack from the rejection reason object to the rejection stack. r=aswan
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6cbfda78737876618f2a855df465dd5aa711139
Bug 1455176: Follow-up: Fix build bustage from xpcshell self-test. r=bustage CLOSED TREE
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0a18dfd7cd23762e72877421153491159032fac
Bug 1455176: Follow-up: Fix devtools bustage in straggler tests that still use Task global. r=bustage

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f6281311d0ba6328cf6db0c1d6d300e7cd44ac5
Bug 1455176: Follow-up: Fix test which was added after SpawnTask.js rename. r=bustage CLOSED TREE
https://hg.mozilla.org/integration/mozilla-inbound/rev/be575e9c66e18816eb90884b718342906c00f548
Bug 1455176: Follow-up: Fix devtools bustage in more straggler tests that still use Task global. r=bustage
https://hg.mozilla.org/integration/mozilla-inbound/rev/096da0066db8e6b4c825e82024491c69762a4ae7
Bug 1455176: Follow-up: Fix weird, flaky Windows chrome mochitest failures. r=bustage CLOSED TREE
(Most of these follow-ups were actually for bug 1454813...)
You need to log in before you can comment on or make changes to this bug.