Closed Bug 1455204 Opened 3 years ago Closed 3 years ago
Hide close toggle button of Browser Toolbox and Browser Content Toolbox
333.26 KB, image/png
59 bytes, text/x-review-board-request
This is a small change of UI. Currently, Browser Toolbox and Browser Content Toolbox display close button. However, all of the platforms will display window close button. So I think we don't need to display this close button in this cases. An attachment is a comparison between each platform.
We don't set setCanCloseButton if the target is remote or window: https://searchfox.org/mozilla-central/rev/59a9a86553e9bfd9277202748ff791fd9bc0713b/devtools/client/framework/toolbox.js#1084-1086 Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb75e3e834e3eebbc93ffaccde6b1bcf6d2421bf
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
Comment on attachment 8969171 [details] Bug 1455204 - Hide close button on browser console and browser toolbox. https://reviewboard.mozilla.org/r/237904/#review243926 Looks good to me, thanks Mantaroh!
Attachment #8969171 - Flags: review?(jdescottes) → review+
Comment on attachment 8969171 [details] Bug 1455204 - Hide close button on browser console and browser toolbox. https://reviewboard.mozilla.org/r/237904/#review243926 Thanks, Julian!
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/52c80343da5c Hide close button on browser console and browser toolbox. r=jdescottes
I have reproduced this issue using Firefox 61.0a1 (2018.04.18) on Ubuntu 14.04 x64. I can confirm this issue is fixed, I verified using Firefox 61.0b9 on Win 10 x64, Mac OS X 10.13 and Ubuntu 14.04 x64.
You need to log in before you can comment on or make changes to this bug.