Closed
Bug 1455204
Opened 5 years ago
Closed 5 years ago
Hide close toggle button of Browser Toolbox and Browser Content Toolbox.
Categories
(DevTools :: Framework, enhancement)
DevTools
Framework
Tracking
(firefox61 verified)
VERIFIED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | verified |
People
(Reporter: mantaroh, Assigned: mantaroh)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The comparison of the close button between each platforms.
This is a small change of UI. Currently, Browser Toolbox and Browser Content Toolbox display close button. However, all of the platforms will display window close button. So I think we don't need to display this close button in this cases. An attachment is a comparison between each platform.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
We don't set setCanCloseButton if the target is remote or window: https://searchfox.org/mozilla-central/rev/59a9a86553e9bfd9277202748ff791fd9bc0713b/devtools/client/framework/toolbox.js#1084-1086 Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb75e3e834e3eebbc93ffaccde6b1bcf6d2421bf
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
|
||
Comment 4•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8969171 [details] Bug 1455204 - Hide close button on browser console and browser toolbox. https://reviewboard.mozilla.org/r/237904/#review243926 Looks good to me, thanks Mantaroh!
Attachment #8969171 -
Flags: review?(jdescottes) → review+
|
|
Assignee | |
Comment 5•5 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8969171 [details] Bug 1455204 - Hide close button on browser console and browser toolbox. https://reviewboard.mozilla.org/r/237904/#review243926 Thanks, Julian!
Pushed by mantaroh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/52c80343da5c Hide close button on browser console and browser toolbox. r=jdescottes
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/52c80343da5c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
I have reproduced this issue using Firefox 61.0a1 (2018.04.18) on Ubuntu 14.04 x64. I can confirm this issue is fixed, I verified using Firefox 61.0b9 on Win 10 x64, Mac OS X 10.13 and Ubuntu 14.04 x64.
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•