Closed
Bug 1455243
Opened 6 years ago
Closed 6 years ago
Remove duplicate gIdentityHandler implementation from browser.js
Categories
(Firefox :: Site Identity, enhancement, P1)
Firefox
Site Identity
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: dao, Assigned: johannh)
References
Details
Attachments
(1 file)
D'oh. Bug 1440247 was supposed to remove this but didn't.
Assignee | ||
Comment 1•6 years ago
|
||
Oh, wow, yeah.
Assignee | ||
Comment 2•6 years ago
|
||
Prathiksha, do you have time to fix this? Could you look at differences between the two implementations? I.e. what changes when you just copy the browser.js version into browser-siteIdentity.js again? If we're lucky it's not much...
Flags: needinfo?(prathikshaprasadsuman)
Assignee | ||
Comment 3•6 years ago
|
||
Seems like nothing changed, I'll make a patch before someone ends up changing this...
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Flags: needinfo?(prathikshaprasadsuman)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=17e69c8aa92eeae866fc76d3669d3b551592f755
Assignee | ||
Updated•6 years ago
|
Priority: -- → P1
Reporter | ||
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8969215 [details] Bug 1455243 - Remove duplicate gIdentityHandler implementation from browser.js. https://reviewboard.mozilla.org/r/237942/#review243654
Attachment #8969215 -
Flags: review?(dao+bmo) → review+
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3efb974893b5 Remove duplicate gIdentityHandler implementation from browser.js. r=dao
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3efb974893b5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•