Closed Bug 1455243 Opened Last year Closed Last year

Remove duplicate gIdentityHandler implementation from browser.js

Categories

(Firefox :: Site Identity and Permission Panels, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: dao, Assigned: johannh)

References

Details

Attachments

(1 file)

D'oh. Bug 1440247 was supposed to remove this but didn't.
Oh, wow, yeah.
Prathiksha, do you have time to fix this? Could you look at differences between the two implementations? I.e. what changes when you just copy the browser.js version into browser-siteIdentity.js again? If we're lucky it's not much...
Flags: needinfo?(prathikshaprasadsuman)
Seems like nothing changed, I'll make a patch before someone ends up changing this...
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Flags: needinfo?(prathikshaprasadsuman)
Priority: -- → P1
Comment on attachment 8969215 [details]
Bug 1455243 - Remove duplicate gIdentityHandler implementation from browser.js.

https://reviewboard.mozilla.org/r/237942/#review243654
Attachment #8969215 - Flags: review?(dao+bmo) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3efb974893b5
Remove duplicate gIdentityHandler implementation from browser.js. r=dao
https://hg.mozilla.org/mozilla-central/rev/3efb974893b5
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.