Closed
Bug 1455275
Opened 6 years ago
Closed 6 years ago
Instrument deactivation of RDM and Split Console with event telemetry
Categories
(DevTools :: General, defect, P2)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: miker, Assigned: miker)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The events are documented in the Amplitude ping format: https://docs.google.com/spreadsheets/d/1PvLMiSQeq-XMPhgUr1GpVGCtg64XwGhOMQ8hZSYR07Q/edit#gid=879531055
Assignee | ||
Comment 1•6 years ago
|
||
So we need to gather the following: devtools.main: deactivate: objects: ["responsive_design_mode", "split_console"] bug_numbers: [1455275] notification_emails: ["dev-developer-tools@lists.mozilla.org", "hkirschner@mozilla.com"] record_in_processes: ["main"] description: User deactivates the responsive_design_mode or split_console in the devtools toolbox. release_channel_collection: opt-out expiry_version: never extra_keys: host: "Toolbox host (positioning): bottom, side, window or other." width: Toolbox width rounded up to the nearest 50px. 1. Services.telemetry.recordEvent("devtools.main", "deactivate", "responsive_design_mode", null, { "host": "...", "width": "..." }); 2. Services.telemetry.recordEvent("devtools.main", "deactivate", "split_console", null, { "host": "...", "width": "..." });
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8969243 -
Flags: review?(andrei.br92)
Comment 3•6 years ago
|
||
Comment on attachment 8969243 [details]
data-review.txt
I think one of the data stewards should review this.
Attachment #8969243 -
Flags: review?(andrei.br92) → review?(francois)
Comment 4•6 years ago
|
||
Comment on attachment 8969243 [details] data-review.txt > 8. If this data collection is default on, what is the opt-out mechanism for users? > The event is submitted by default on release and pre-release channels, unless the user has opted out. No need to fix this in this bug since my data review will include this answer too, but in the future, the answer to this question should point to what the opt out is for users. In this case: users can disable telemetry using the setting in preferences
Comment 5•6 years ago
|
||
(In reply to Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe] from comment #0) > The events are documented in the Amplitude ping format: > https://docs.google.com/spreadsheets/d/1PvLMiSQeq- > XMPhgUr1GpVGCtg64XwGhOMQ8hZSYR07Q/edit#gid=879531055 That document is not publicly available. Will the events we are collecting be publicly documented somewhere else too?
Flags: needinfo?(mratcliffe)
Assignee | ||
Comment 6•6 years ago
|
||
No, everything is for internal use only.
Flags: needinfo?(mratcliffe)
Comment 7•6 years ago
|
||
Comment on attachment 8969243 [details] data-review.txt 1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate? Yes, in Events.yaml. 2) Is there a control mechanism that allows the user to turn the data collection on and off? Yes, telemetry setting. 3) If the request is for permanent data collection, is there someone who will monitor the data over time?** Yes, Harald Kirschner. 4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under? ** Category 2. 5) Is the data collection request for default-on or default-off? Default-on, all channels. 6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)? No. 7) Is the data collection covered by the existing Firefox privacy notice? Yes. 8) Does there need to be a check-in in the future to determine whether to renew the data? No, permanent.
Attachment #8969243 -
Flags: review?(francois) → review+
Assignee | ||
Comment 8•6 years ago
|
||
responsive_design_mode exceeds the max length of 20 characters so using responsive_design instead.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Comment hidden (mozreview-request) |
Comment 10•6 years ago
|
||
mozreview-review |
Comment on attachment 8970153 [details] Bug 1455275 - Instrument deactivation of RDM and Split Console with event telemetry https://reviewboard.mozilla.org/r/238956/#review244578 this looks good!
Attachment #8970153 -
Flags: review?(ystartsev) → review+
Comment hidden (mozreview-request) |
Comment 12•6 years ago
|
||
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e691c7ff5dd Instrument deactivation of RDM and Split Console with event telemetry r=yulia
Comment 13•6 years ago
|
||
Backed out changeset 6e691c7ff5dd (bug 1455275) for dt failures in devtools/client/responsive.html/test/browser/browser_exit_button.js on a CLOSED TREE Problematic push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6e691c7ff5dd229d4ad84177e52d51e512bb0a92&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception Failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&fromchange=4b851036974da2dacf2985a00d93ddb2e46a19fd&selectedJob=175294711 Backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fc39571cc03ac7f5fcff5f7ec047638331d09165&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception Log: https://treeherder.mozilla.org/logviewer.html#?job_id=175294711&repo=autoland&lineNumber=11930 [task 2018-04-24T10:28:57.266Z] 10:28:57 INFO - TEST-UNEXPECTED-FAIL | devtools/client/responsive.html/test/browser/browser_exit_button.js | A promise chain failed to handle a rejection: this.tab.linkedBrowser is null - stack: _setupListeners@resource://devtools/shared/base-loader.js -> resource://devtools/client/framework/target.js:500:5
Flags: needinfo?(mratcliffe)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•6 years ago
|
No longer blocks: devtools-analytics
Comment 17•6 years ago
|
||
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1bc7ca9eee85 Instrument deactivation of RDM and Split Console with event telemetry r=yulia
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(mratcliffe)
Comment 18•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1bc7ca9eee85
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•