Closed
Bug 1455285
Opened 6 years ago
Closed 6 years ago
Blank space shows at the the bottom while dynamic toolbar is partially onscreen
Categories
(Firefox for Android Graveyard :: Toolbar, defect, P1)
Tracking
(firefox59 unaffected, firefox60 unaffected, firefox61+ fixed)
VERIFIED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | + | fixed |
People
(Reporter: kats, Assigned: botond)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
For the last week or so I've been seeing blank white space at the bottom of the screen when the dynamic toolbar is partially visible. The size of the blank space corresponds to the amount of the toolbar that is visible. Fennec Nightly, on a Sony Xperia XZ1 with Android 8.0 STR: - Go to https://staktrace.github.io/moz-pages/bugmash.html - Zoom in a bit - Scroll up and down
Reporter | ||
Comment 2•6 years ago
|
||
I bisected using mozregression, it gave me this: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=09c9390d42d6bc95ffd2e3a3933053d718a1ebe3&tochange=a2866a322bbb526bd1f9f69d352e5389dce849b5 Not what I would have guessed, but I guess not totally implausible? I verified the last good/first bad again to make sure. The change does touch some stuff in AsyncCompositionManager.cpp which might have caused this.
Blocks: 1420512
Reporter | ||
Updated•6 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regressionwindow-wanted
OS: Unspecified → Android
Hardware: Unspecified → All
Version: 57 Branch → Firefox 61
Assignee | ||
Comment 3•6 years ago
|
||
Apologies for the additional regression from bug 1420512. I don't have an Android build to test this with right now, but the attached patch might fix the problem.
Assignee | ||
Comment 4•6 years ago
|
||
(After catching a similar regression during the review of bug 1454485, I audited uses of ScrollbarData::mDirection to make sure that they reflect the fact that it's now set for both thumb and scrollbar container layers, but I missed the Android-only uses...)
Reporter | ||
Comment 5•6 years ago
|
||
I started a try push with the patch, will test it when it's done: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c67d0853ec2e46cd03106fadc38a9448e188db53
Updated•6 years ago
|
Assignee: nobody → botond
status-firefox59:
--- → unaffected
status-firefox60:
--- → unaffected
Priority: -- → P1
Reporter | ||
Comment 6•6 years ago
|
||
Comment on attachment 8969398 [details] [diff] [review] Potential fix Review of attachment 8969398 [details] [diff] [review]: ----------------------------------------------------------------- Yup, the try push with this fix doesn't have the issue. Thanks!
Attachment #8969398 -
Flags: review+
Assignee | ||
Comment 7•6 years ago
|
||
Great, thanks for testing!
Comment hidden (mozreview-request) |
Reporter | ||
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8969687 [details] Bug 1455285 - In MoveScrollbarForLayerMargin(), move the actual scrollbar thumb layer, not the scrollbar container layer. https://reviewboard.mozilla.org/r/238484/#review244242
Attachment #8969687 -
Flags: review?(bugmail) → review+
Assignee | ||
Updated•6 years ago
|
Attachment #8969398 -
Attachment is obsolete: true
Comment 10•6 years ago
|
||
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6817a2e39494 In MoveScrollbarForLayerMargin(), move the actual scrollbar thumb layer, not the scrollbar container layer. r=kats
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6817a2e39494
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•