Closed Bug 1455285 Opened 2 years ago Closed 2 years ago

Blank space shows at the the bottom while dynamic toolbar is partially onscreen

Categories

(Firefox for Android :: Toolbar, defect, P1)

Firefox 61
All
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 61
Tracking Status
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 + fixed

People

(Reporter: kats, Assigned: botond)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

For the last week or so I've been seeing blank white space at the bottom of the screen when the dynamic toolbar is partially visible. The size of the blank space corresponds to the amount of the toolbar that is visible.

Fennec Nightly, on a Sony Xperia XZ1 with Android 8.0

STR:
- Go to https://staktrace.github.io/moz-pages/bugmash.html
- Zoom in a bit
- Scroll up and down
I wasn't able to reproduce on my HTC M8 w/ Android 7.1, FWIW.
I bisected using mozregression, it gave me this:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=09c9390d42d6bc95ffd2e3a3933053d718a1ebe3&tochange=a2866a322bbb526bd1f9f69d352e5389dce849b5

Not what I would have guessed, but I guess not totally implausible? I verified the last good/first bad again to make sure.

The change does touch some stuff in AsyncCompositionManager.cpp which might have caused this.
Blocks: 1420512
Has Regression Range: --- → yes
Has STR: --- → yes
OS: Unspecified → Android
Hardware: Unspecified → All
Version: 57 Branch → Firefox 61
Attached patch Potential fix (obsolete) — Splinter Review
Apologies for the additional regression from bug 1420512.

I don't have an Android build to test this with right now, but the attached patch might fix the problem.
(After catching a similar regression during the review of bug 1454485, I audited uses of ScrollbarData::mDirection to make sure that they reflect the fact that it's now set for both thumb and scrollbar container layers, but I missed the Android-only uses...)
Assignee: nobody → botond
Priority: -- → P1
Comment on attachment 8969398 [details] [diff] [review]
Potential fix

Review of attachment 8969398 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, the try push with this fix doesn't have the issue. Thanks!
Attachment #8969398 - Flags: review+
Great, thanks for testing!
Comment on attachment 8969687 [details]
Bug 1455285 - In MoveScrollbarForLayerMargin(), move the actual scrollbar thumb layer, not the scrollbar container layer.

https://reviewboard.mozilla.org/r/238484/#review244242
Attachment #8969687 - Flags: review?(bugmail) → review+
Attachment #8969398 - Attachment is obsolete: true
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6817a2e39494
In MoveScrollbarForLayerMargin(), move the actual scrollbar thumb layer, not the scrollbar container layer. r=kats
https://hg.mozilla.org/mozilla-central/rev/6817a2e39494
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.