Closed Bug 1455285 Opened 2 years ago Closed 2 years ago
Blank space shows at the the bottom while dynamic toolbar is partially onscreen
Bug 1455285 - In MoveScrollbarForLayerMargin(), move the actual scrollbar thumb layer, not the scrollbar container layer.
59 bytes, text/x-review-board-request
For the last week or so I've been seeing blank white space at the bottom of the screen when the dynamic toolbar is partially visible. The size of the blank space corresponds to the amount of the toolbar that is visible. Fennec Nightly, on a Sony Xperia XZ1 with Android 8.0 STR: - Go to https://staktrace.github.io/moz-pages/bugmash.html - Zoom in a bit - Scroll up and down
I bisected using mozregression, it gave me this: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=09c9390d42d6bc95ffd2e3a3933053d718a1ebe3&tochange=a2866a322bbb526bd1f9f69d352e5389dce849b5 Not what I would have guessed, but I guess not totally implausible? I verified the last good/first bad again to make sure. The change does touch some stuff in AsyncCompositionManager.cpp which might have caused this.
2 years ago
Has Regression Range: --- → yes
Has STR: --- → yes
OS: Unspecified → Android
Hardware: Unspecified → All
Version: 57 Branch → Firefox 61
Apologies for the additional regression from bug 1420512. I don't have an Android build to test this with right now, but the attached patch might fix the problem.
(After catching a similar regression during the review of bug 1454485, I audited uses of ScrollbarData::mDirection to make sure that they reflect the fact that it's now set for both thumb and scrollbar container layers, but I missed the Android-only uses...)
I started a try push with the patch, will test it when it's done: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c67d0853ec2e46cd03106fadc38a9448e188db53
Comment on attachment 8969398 [details] [diff] [review] Potential fix Review of attachment 8969398 [details] [diff] [review]: ----------------------------------------------------------------- Yup, the try push with this fix doesn't have the issue. Thanks!
Attachment #8969398 - Flags: review+
Great, thanks for testing!
Comment on attachment 8969687 [details] Bug 1455285 - In MoveScrollbarForLayerMargin(), move the actual scrollbar thumb layer, not the scrollbar container layer. https://reviewboard.mozilla.org/r/238484/#review244242
Attachment #8969687 - Flags: review?(bugmail) → review+
Attachment #8969398 - Attachment is obsolete: true
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/6817a2e39494 In MoveScrollbarForLayerMargin(), move the actual scrollbar thumb layer, not the scrollbar container layer. r=kats
You need to log in before you can comment on or make changes to this bug.