Closed
Bug 1455292
Opened 6 years ago
Closed 6 years ago
Avoid verification for verified Firefox Accounts in TPS
Categories
(Firefox :: Sync, enhancement)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: davehunt, Assigned: davehunt)
Details
Attachments
(1 file)
Currently TPS attempts to verify the Firefox Account when signing in, regardless of whether the account is already verified. I discovered this when using TPS for testing iOS sync integration, which a freshly created/verified Firefox Account. In this scenario, instead of finding the verification email, TPS is finding an email notification of a new device sign-in. This results in opening the change password URL in the email's "x-link" header. I've been able to resolve this by only attempting to verify the account when the return value from FxAccountsClient.signIn indicates that the account is not verified.
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8969277 [details] Bug 1455292 - Avoid verification for verified Firefox Accounts in TPS; https://reviewboard.mozilla.org/r/238002/#review243832 This makes sense, here's hoping it doesn't introduce any race conditions against code that was expecting to wait a while before verification :p (TPS is very robust engineering)
Attachment #8969277 -
Flags: review?(tchiovoloni) → review+
Pushed by dhunt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a8a951f488d2 Avoid verification for verified Firefox Accounts in TPS; r=tcsc
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a8a951f488d2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•