Closed
Bug 1455318
Opened 8 years ago
Closed 8 years ago
Refactor checks and maybe parser into smaller files
Categories
(Localization Infrastructure and Tools :: compare-locales, enhancement)
Localization Infrastructure and Tools
compare-locales
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: Pike)
Details
Attachments
(5 files)
|
59 bytes,
text/x-review-board-request
|
stas
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
stas
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
stas
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
stas
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
stas
:
review+
|
Details |
checks.py is getting large, and so is parser.py.
Let's see how those look if we shred them into pieces in own modules.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8969286 [details]
bug 1455318, checks.py -> checks/__init__.py,
https://reviewboard.mozilla.org/r/238016/#review243718
Attachment #8969286 -
Flags: review?(stas) → review+
|
|
||
Comment 7•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8969287 [details]
bug 1455318, checks.Checker -> checks.base.Checker,
https://reviewboard.mozilla.org/r/238018/#review243714
Attachment #8969287 -
Flags: review?(stas) → review+
|
|
||
Comment 8•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8969288 [details]
bug 1455318, checks.FluentChecker -> checks.fluent.FluentChecker,
https://reviewboard.mozilla.org/r/238020/#review243720
Attachment #8969288 -
Flags: review?(stas) → review+
|
|
||
Comment 9•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8969289 [details]
bug 1455318, checks.DTDChecker -> checks.dtd.DTDChecker,
https://reviewboard.mozilla.org/r/238022/#review243722
Attachment #8969289 -
Flags: review?(stas) → review+
|
|
||
Comment 10•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8969290 [details]
bug 1455318, check.PropertiesChecker -> checks.properties.PropertiesChecker,
https://reviewboard.mozilla.org/r/238024/#review243724
Attachment #8969290 -
Flags: review?(stas) → review+
|
Assignee | |
Comment 11•8 years ago
|
||
Did the full thing on the parser, too, and some linting fixes:
https://hg.mozilla.org/l10n/compare-locales/pushloghtml?changeset=02192f6b7bcde772dec7a5bb333777206978cea9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•