1455335 - Font editor: reuse font family block from font overview in font editor

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement)

Description

[Razvan Caliman [:rcaliman]]

Extract a component with  the font name, URL and URL copy behaviour from the font overview and reuse it in the font editor.

Designs:
https://mozilla.invisionapp.com/share/Z3F7OGCTK#/screens/279202133

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1455335 - Extract font name and origin into reusable component.

- Extract font name and origin (URL + copy URL) into FontMeta component.
- Reuse FontMeta in font overview and font editor.
- Tweak CSS for improved spacing and flex-grow behaviour.

Review commit: https://reviewboard.mozilla.org/r/238856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238856/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8970083 [details]
Bug 1455335 - Extract font name and origin into reusable component.

https://reviewboard.mozilla.org/r/238856/#review245098

::: devtools/client/inspector/fonts/components/Font.js:14
(Diff revision 1)
>  const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
>  
> +const FontMeta = createFactory(require("./FontMeta"));
>  const FontPreview = createFactory(require("./FontPreview"));
>  
>  loader.lazyRequireGetter(this, "clipboardHelper", "devtools/shared/platform/clipboard");

Remove this since it's not used here anymore and wouldn't be caught by ESLint.

::: devtools/client/inspector/fonts/components/FontEditor.js:82
(Diff revision 1)
>    }
>  
> +  renderFontFamily(font) {
> +    return dom.label(
> +      {
> +        className: "font-control font-control--family",

s/font-control--family/font-control-family

::: devtools/client/inspector/fonts/components/FontEditor.js:88
(Diff revision 1)
> +      },
> +      dom.span(
> +        {
> +          className: "font-control-label",
> +        },
> +        "Family"

Needs to be localized.

Comment 3

[Razvan Caliman [:rcaliman]]

Comment on attachment 8970083 [details]
Bug 1455335 - Extract font name and origin into reusable component.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238856/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85a3c207b99e
Extract font name and origin into reusable component. r=gl

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/85a3c207b99e