Font editor: reuse font family block from font overview in font editor

RESOLVED FIXED in Firefox 61

Status

RESOLVED FIXED
10 months ago
8 months ago

People

(Reporter: rcaliman, Assigned: rcaliman)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 61

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
Extract a component with  the font name, URL and URL copy behaviour from the font overview and reuse it in the font editor.

Designs:
https://mozilla.invisionapp.com/share/Z3F7OGCTK#/screens/279202133
Comment hidden (mozreview-request)

Comment 2

10 months ago
mozreview-review
Comment on attachment 8970083 [details]
Bug 1455335 - Extract font name and origin into reusable component.

https://reviewboard.mozilla.org/r/238856/#review245098

::: devtools/client/inspector/fonts/components/Font.js:14
(Diff revision 1)
>  const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
>  
> +const FontMeta = createFactory(require("./FontMeta"));
>  const FontPreview = createFactory(require("./FontPreview"));
>  
>  loader.lazyRequireGetter(this, "clipboardHelper", "devtools/shared/platform/clipboard");

Remove this since it's not used here anymore and wouldn't be caught by ESLint.

::: devtools/client/inspector/fonts/components/FontEditor.js:82
(Diff revision 1)
>    }
>  
> +  renderFontFamily(font) {
> +    return dom.label(
> +      {
> +        className: "font-control font-control--family",

s/font-control--family/font-control-family

::: devtools/client/inspector/fonts/components/FontEditor.js:88
(Diff revision 1)
> +      },
> +      dom.span(
> +        {
> +          className: "font-control-label",
> +        },
> +        "Family"

Needs to be localized.
Attachment #8970083 - Flags: review?(gl) → review+
Comment hidden (mozreview-request)

Comment 4

10 months ago
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85a3c207b99e
Extract font name and origin into reusable component. r=gl

Comment 5

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/85a3c207b99e
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.