Closed
Bug 1455335
Opened 6 years ago
Closed 6 years ago
Font editor: reuse font family block from font overview in font editor
Categories
(DevTools :: Inspector, enhancement)
DevTools
Inspector
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
References
Details
Attachments
(1 file)
Extract a component with the font name, URL and URL copy behaviour from the font overview and reuse it in the font editor. Designs: https://mozilla.invisionapp.com/share/Z3F7OGCTK#/screens/279202133
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8970083 [details] Bug 1455335 - Extract font name and origin into reusable component. https://reviewboard.mozilla.org/r/238856/#review245098 ::: devtools/client/inspector/fonts/components/Font.js:14 (Diff revision 1) > const PropTypes = require("devtools/client/shared/vendor/react-prop-types"); > > +const FontMeta = createFactory(require("./FontMeta")); > const FontPreview = createFactory(require("./FontPreview")); > > loader.lazyRequireGetter(this, "clipboardHelper", "devtools/shared/platform/clipboard"); Remove this since it's not used here anymore and wouldn't be caught by ESLint. ::: devtools/client/inspector/fonts/components/FontEditor.js:82 (Diff revision 1) > } > > + renderFontFamily(font) { > + return dom.label( > + { > + className: "font-control font-control--family", s/font-control--family/font-control-family ::: devtools/client/inspector/fonts/components/FontEditor.js:88 (Diff revision 1) > + }, > + dom.span( > + { > + className: "font-control-label", > + }, > + "Family" Needs to be localized.
Attachment #8970083 -
Flags: review?(gl) → review+
Comment hidden (mozreview-request) |
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/85a3c207b99e Extract font name and origin into reusable component. r=gl
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/85a3c207b99e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•3 years ago
|
Component: Inspector: Fonts → Inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•