Closed Bug 1455343 Opened 6 years ago Closed 5 years ago

Login form on webassessor.com not recognized, username and password won't save

Categories

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox61 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: gkommet, Assigned: MattN)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [fixed by bug 1287202])

When logging in to the Kryterion Webassessor site, Firefox does not recognize the username and password fields and thus does not offer to save my credentials.

The login page can be found here:

https://www.webassessor.com/wa.do?page=publicHome&branding=SALESFORCE

The password <input> element is marked as type="password" and the username <input> element is marked as type="text" and is the element immediately preceding the password element. I'm a JS novice, but from my (possibly badly wrong) reading of the _getPasswordFields function in nsLoginManager.js it looks like that should meet the criteria to be detected as a login form.

What could be throwing Firefox off is that there are two forms on the page, and the one that contains the username and password has no name, no method, and no action defined in the HTML. The second form, full of "hidden" inputs, has all three. From my (again, novice) reading of the POST contents it looks like parts of both forms are combined when the credentials are sent to the server.

I have confirmed that I have not denied the site the ability to save passwords and that Firefox will offer to save passwords for other sites.

I'm filing this under the General component as I don't see one that seems more specific to Password Manager.
Component: General → Password Manager
Product: Firefox → Toolkit
Component: Password Manager → Password Manager: Site Compatibility
Priority: -- → P3
When I look at the Network Monitor log, I can see Webassessor is POSTing JSON data to https://www.webassessor.com/loginservice/login like so:

{"loginName":"foo","password":"foo","csrfToken":"B9nonocjtX7Uv","branding":"SALESFORCE","shopping":""}

Since Webassessor is doing an AJAX ("AJAJ"?) POST instead of submitting form data, I'll mark this bug as depending on Bug 442524.
Depends on: 442524
No longer depends on: 442524
Depends on: formless-logins

Can you please confirm that this works with tomorrow's Firefox Nightly version now that bug 1287202 is fixed? https://nightly.mozilla.org/

Thanks

Flags: needinfo?(gkommet)

Sorry for the delay. I can confirm that Nightly 68 build 20190328101229 successfully saves the credentials (username and password)! I also tested in DevEd 67 just to be sure it was fixed by bug 1287202 and not some unrelated change to to the site, and it was definitely not the site.

One odd behavior I observed is that during subsequent visits Nightly doesn't recognize the "loginInput" field as the username field for auto-fill.

It does recognize the "passwordInput" field, presumably because it is flagged as type "password". It also recognized "loginInput" as the username when initially offering to store the login credentials.

Flags: needinfo?(gkommet)

(In reply to Andy from comment #3)

Sorry for the delay. I can confirm that Nightly 68 build 20190328101229 successfully saves the credentials (username and password)! I also tested in DevEd 67 just to be sure it was fixed by bug 1287202 and not some unrelated change to to the site, and it was definitely not the site.

Great!

One odd behavior I observed is that during subsequent visits Nightly doesn't recognize the "loginInput" field as the username field for auto-fill.

It does recognize the "passwordInput" field, presumably because it is flagged as type "password". It also recognized "loginInput" as the username when initially offering to store the login credentials.

Yeah, finding the right username fields to fill is harder than finding the field to save. Our main focus right now is getting the passwords saved but we will improve detection of username fields later.

Assignee: nobody → MattN+bmo
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Depends on: 1287202
Resolution: --- → FIXED
Whiteboard: [fixed by bug 1287202]
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.