Closed
Bug 1455359
Opened 6 years ago
Closed 6 years ago
Remove autoCheck attribute from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement
Categories
(Core :: XUL, task, P5)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
This attribute never seems to be used on buttons or checkboxes: - https://searchfox.org/mozilla-central/search?q=autocheck&path=.xul - https://searchfox.org/mozilla-central/search?q=autocheck&path=.js There's a separate attribute autoCheck used for menus (https://searchfox.org/mozilla-central/search?q=atoms%3A%3Aautocheck&path=), but those look unrelated. There's also a XBL property that could be removed at https://searchfox.org/mozilla-central/rev/59a9a86553e9bfd9277202748ff791fd9bc0713b/toolkit/content/widgets/button.xml#76.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8969358 -
Flags: review?(enndeakin)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8969358 -
Flags: review?(enndeakin)
Comment 4•6 years ago
|
||
Triage: P5 - Feature request for non-primary UI that is not on the roadmap; Code cleanup.
Priority: -- → P5
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8969358 [details] Bug 1455359 - Remove autoCheck attribute from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement; https://reviewboard.mozilla.org/r/238100/#review244668
Attachment #8969358 -
Flags: review?(enndeakin) → review+
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6633de988dab Remove autoCheck attribute from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement; r=enndeakin+6102
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6633de988dab
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 8•6 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•