Closed Bug 1455446 Opened 2 years ago Closed 2 years ago

Set CLOEXEC on socket FDs

Categories

(Core :: Networking, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There are currently a bunch of places where we spawn processes, and those processes unintentionally inherit our network socket FDs. This unfortunately is not always easy to fix (especially on Unix-ish platforms), but setting CLOEXEC on socket FDs should at least ameliorate the problem. It doesn't rule out the possibility of FDs being inherited in a race, but it should at least prevent it most of the time.
Comment on attachment 8969446 [details]
Bug 1455446: Set CLOEXEC on socket FDs.

https://reviewboard.mozilla.org/r/238210/#review244130
Attachment #8969446 - Flags: review?(dd.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/c5f309cfe1cb
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
See Also: → 1463873
You need to log in before you can comment on or make changes to this bug.