Closed Bug 1455448 Opened 7 years ago Closed 7 years ago

Don't include `firefox` in the decision task index.

Categories

(Firefox Build System :: Task Configuration, task)

3 Branch
task
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: tomprince, Assigned: tomprince)

Details

Attachments

(2 files)

The decision task is used for everything built as part of a push (for mozilla-central, this is firefox, devedition and fennec, as well as tasks that aren't strictly part of any product). Thus, having `firefox` encoded as part of the decision task doesn't make sense. comm-central currently uses `thunderbird` instead of `firefox`. This means that tools that want to support both need to encode that knowledge (as well as the `gecko.` vs. `comm.` prefix to the routes, but that has security implications).
The decision task is used for everything built as part of a push (for mozilla-central, this is firefox, devedition and fennec, as well as tasks that aren't strictly part of any product). Thus, having `firefox` encoded as part of the decision task doesn't make sense. This changes the route from index.gecko.v2.${repository.project}.latest.firefox.decision to index.gecko.v2.${repository.project}.latest.taskgraph.decision while leaving the latter for backwards compatability with tools that expect it.
Comment on attachment 8969454 [details] Bug 1455448: Don't include `firefox` in the decision task index. Rail Aliiev [:rail] ⌚️ET has approved the revision. https://phabricator.services.mozilla.com/D996
Attachment #8969454 - Flags: review+
Comment on attachment 8969454 [details] Bug 1455448: Don't include `firefox` in the decision task index. Dustin J. Mitchell [:dustin] pronoun: he has approved the revision. https://phabricator.services.mozilla.com/D996
Attachment #8969454 - Flags: review+
Comment on attachment 8969454 [details] Bug 1455448: Don't include `firefox` in the decision task index. Michael Shal [:mshal] has approved the revision. https://phabricator.services.mozilla.com/D996
Attachment #8969454 - Flags: review+
Comment on attachment 8969454 [details] Bug 1455448: Don't include `firefox` in the decision task index. Flag set by Rail Aliiev [:rail] ⌚️ET is no longer active. Flag set by Dustin J. Mitchell [:dustin] pronoun: he is no longer active. Flag set by Michael Shal [:mshal] is no longer active. https://phabricator.services.mozilla.com/D996
Attachment #8969454 - Flags: review+
Comment on attachment 8969454 [details] Bug 1455448: Don't include `firefox` in the decision task index. Dustin J. Mitchell [:dustin] pronoun: he has approved the revision. Michael Shal [:mshal] has approved the revision. Rail Aliiev [:rail] ⌚️ET has approved the revision. Justin Wood (:Callek) has approved the revision. https://phabricator.services.mozilla.com/D996
Attachment #8969454 - Flags: review+
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/mozilla-central/rev/28db2c96ac69 Don't include `firefox` in the decision task index; r=dustin,mshal,rail,Callek a=release
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/305addd57798 [taskcluster] Use `taskgraph` indexed decision tasks for finding parameters; r=me
Assignee: nobody → mozilla
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/comm-central/rev/31ad23dc587d Don't include `thunderbird` in the decision task index; r=me
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: