Closed
Bug 1455458
Opened 6 years ago
Closed 6 years ago
De-IDLify JS access to blocklist service
Categories
(Toolkit :: Add-ons Manager, enhancement)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(1 file)
There's no reason for the JS-only side of the blocklist service to go through XPConnect. It just slows things down and makes maintenance harder.
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8969489 [details] Bug 1455458: De-XPIDLify the blocklist service. https://reviewboard.mozilla.org/r/238238/#review244132 ::: toolkit/mozapps/extensions/nsBlocklistService.js:1505 (Diff revision 1) > QueryInterface: XPCOMUtils.generateQI([Ci.nsIObserver, > Ci.nsIBlocklistService, > Ci.nsITimerCallback]), > }; > > -/** > +/* Out of interest, why de-jsdoc this? ::: tools/lint/eslint/eslint-plugin-mozilla/lib/rules/use-services.js:49 (Diff revision 1) > + if (property.value.elements.length > 1) { > - interfaces[property.key.name] = property.value.elements[1].value; > + interfaces[property.key.name] = property.value.elements[1].value; > - } > + } > + } Can you add nsIBlocklistService to the list at the top of this file, given that we now won't detect people trying to use it in JS?
Attachment #8969489 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8969489 [details] Bug 1455458: De-XPIDLify the blocklist service. https://reviewboard.mozilla.org/r/238238/#review244132 > Out of interest, why de-jsdoc this? It failed the valid-jsdoc rule because it doesn't document the parameters or return value. Ideally, those should be documented, but we don't really lose anything by making this a non-jsdoc comment, and we gain a lot by turning on the valid-jsdoc rule and fixing the rest of the docs, so *shrug*.
Assignee | ||
Comment 4•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ef55ab924d4117f1c5d4c502e4406357d933e9a Bug 1455458: De-XPIDLify the blocklist service. r=gijs
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6ef55ab924d4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 6•6 years ago
|
||
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•