Closed Bug 1455487 Opened 6 years ago Closed 6 years ago

[RTL] Toolbar overflow icon (>>) should be reversed in RTL mode

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(firefox61 verified)

VERIFIED FIXED
Firefox 61
Tracking Status
firefox61 --- verified

People

(Reporter: birtles, Assigned: mantaroh)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

      No description provided.
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
Comment on attachment 8970452 [details]
Bug 1455487 - Rotate the chevron icon 180 degree when RTL.

https://reviewboard.mozilla.org/r/239224/#review244912

Looks good to me, thanks! 

Some additional context: we seem to sometimes use scaleX(-1) and sometimes rotate(180deg) to perform the rtl/ltr mirroring of our icons. 
No real consistency in the codebase though, so both work for me.
Attachment #8970452 - Flags: review?(jdescottes) → review+
Comment on attachment 8970452 [details]
Bug 1455487 - Rotate the chevron icon 180 degree when RTL.

https://reviewboard.mozilla.org/r/239224/#review244912

Thank you for the review.
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e5a4d5c29bb9
Rotate the chevron icon 180 degree when RTL. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/e5a4d5c29bb9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
I have reproduced this issue using Firefox  61.0a1 RTL buil (2018.04.29) on Ubuntu 14.04 x64.
I can confirm this issue is fixed, I verified using Firefox 61.0b9 on Win 10 x64, Mac OS X 10.13 and Ubuntu 14.04 x64.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.