1455494 - Missing/Bad Bold(?) Fonts on Mac in latest Nightly

Status: VERIFIED FIXED

(Core :: Graphics: Text, defect)

Description

[Aria Beingessner [:Gankra]]

* If you type in the awesome bar, substrings that match what you typed are just missing text (I think those substrings are supposed to be bolded?)

* On github, @names are missing (this is definitely bold -apple-system-font)

Seeing this is vanilla nightly, but webrender is also affected, although slightly differently. Awesome bar is still missing text, but in-page bold -apple-system-font is just *not* bold. 

This suggests the issue is probably in our macos font subsystem.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Also, the preference names of modified prefs in about:config are missing, as they're rendered in bold too. MacOS Nightly, 2018-04-20.

Comment 2

[Ed Lee :Mardak]

Attachment: Sometimes [?] and sometimes blank (nightly left / beta right)

Looking at the inline readme of the activity stream repository:
https://github.com/mozilla/activity-stream/

"README.md" turns into a [?] as well as the "Activity Stream" h1 header. If I adjust the font-weight from 600 to normal / 400, the text appears.

If I remove "-apple-system" from font-family, it also appears.

Not sure why the h2 for "Where should I file bugs?" just disappears vs [?]

Comment 3

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3692b02e7ca290d1098b42757e48d055458ba906&tochange=b673e87d613411b38707fecd3ab6ae7b527d5e65

Comment 4

[Karl Dubost💡 :karlcow]

Yup Confirmed. 
It even breaks some things inside the chrome like the about:firefox window.
:jfkthame Bug 1454598 broke a couple of things ;) GitHub, Twitter, etc.

Comment 5

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

This regression from bug 1454598 causes some text, on websites and in Firefox chrome, to not be displayed on Mac.

Comment 6

[Jonathan Kew [:jfkthame]]

There seems to be something funky about how the -apple-system font deals with variation settings. :\ Investigating; meanwhile, the patches from bug 1454598 have been backed out.

Comment 9

[Jonathan Kew [:jfkthame]]

Turns out the root cause of this was actually bug 1454094, but then bug 1454598 made it widely visible because it hooked up the weight variation axis in the macOS system font.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

marking as fixed since the offending patch was backed out (https://bugzilla.mozilla.org/show_bug.cgi?id=1454598#c21) and we have new nightlies out.