1455555 - Crash when opening variable fonts pages with gfx.downloadable_fonts.otl_validation =False

Status: RESOLVED DUPLICATE of bug 1455531

(Core :: Layout: Text and Fonts, defect)

Description

[roxleitan]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID:20180419224145

[Affected versions]:
Nightly 61.0a1

[Affected platforms]:
Windows 10 X64

1.Launch Nightly 61.0a1 with a new profile
2.Set gfx.downloadable_fonts.otl_validation =False
3.Restart FF
4.Open https://www.axis-praxis.org/specimens/amstelvar

[Expected result]:
The page should be displayed correctly

[Actual result]:
Crash: https://crash-stats.mozilla.com/report/index/5431a9ca-9754-4517-bd0b-978460180420

Comment 1

[roxleitan]

The issue is reproducible also on: https://codepen.io/MSEdgeDev/pen/mxeOGW

Comment 2

[Jonathan Kew [:jfkthame]]

I think this is actually a dupe of bug 1455531, and should be fixed by the backout of bug 1454598.

Comment 3

[Calixte Denizet (:calixte)]

:jfkthame, it appears that one of line appearing in the crash backtrace is not covered by a test (see [1]).
Is it possible to have one ?

[1] https://codecov.io/gh/marco-c/gecko-dev/src/master/gfx/thebes/gfxDWriteFontList.cpp#L685

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to Calixte Denizet (:calixte) from comment #3)
> :jfkthame, it appears that one of line appearing in the crash backtrace is
> not covered by a test (see [1]).
> Is it possible to have one ?
> 
> [1]
> https://codecov.io/gh/marco-c/gecko-dev/src/master/gfx/thebes/
> gfxDWriteFontList.cpp#L685

How is that coverage data generated? Unless it's being done on Win10 Fall Creators Update or later, this code can't be reached because the feature isn't supported on older systems.

Comment 5

[Marco Castelluccio [:marco]]

We're using 1703 on CI, so that feature is not tested on CI.

Comment 6

[roxleitan]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180422223305

I could not reproduce the crash using the latest Nightly 61.0a1(2018-04-22).