Closed Bug 1455581 Opened 2 years ago Closed 2 years ago

Enable ESLint rules no-undef and no-unused-vars for devtools/client/framework/

Categories

(DevTools :: Framework, enhancement)

enhancement
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

no-undef & no-unused-vars are very useful rules to have, as part of bug 1230193 we should continue the roll-out.

I have a patch for this.
Blocks: 1230193
Comment on attachment 8969610 [details]
Bug 1455581 - Enable ESLint rules no-undef and no-unused-vars for devtools/client/framework/.

https://reviewboard.mozilla.org/r/238390/#review244338

Looks good to me, thanks Mark!
Attachment #8969610 - Flags: review?(jdescottes) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e38dafe67941
Enable ESLint rules no-undef and no-unused-vars for devtools/client/framework/. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/e38dafe67941
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.