Closed
Bug 1455623
Opened 6 years ago
Closed 6 years ago
Remove stylo-bindings.zip from artifacts
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
Details
Attachments
(2 files, 1 obsolete file)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Attachment #8969663 -
Flags: review?(core-build-config-reviews) → review?(nfroyd)
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8969663 [details] Bug 1455623 part 1 - Remove stylo-bindings.zip artifact. https://reviewboard.mozilla.org/r/238462/#review244226
Attachment #8969663 -
Flags: review?(nfroyd) → review+
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8969664 [details] Bug 1455623 part 2 - Not copy generated binding files into dist. https://reviewboard.mozilla.org/r/238464/#review244292
Attachment #8969664 -
Flags: review?(emilio) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8969665 [details] Bug 1455623 part 3 - Make bindgen feature unconditional. https://reviewboard.mozilla.org/r/238466/#review244294 Ah, this is unfortunate... As long as Servo keeps testing geckolib on CI this means that I won't be able to send this over to Servo, and I'd need to be careful to not pick this patch in Servo itself. I planned to not cherry-pick the generated code removal but... Anyway, if you don't have further immediate plans for this code, I'd prefer to hold off on this and unbreak the non-bindgen build... But your call. r=me code-wise.
Attachment #8969665 -
Flags: review?(emilio) → review+
Assignee | ||
Comment 7•6 years ago
|
||
Hmmm, since you r+ed bug 1454788, I thought that we've stopped testing geckolib on Servo CI. Maybe that's not true? I don't really think Servo needs to continue testing that as far as VCS sync is not going to continue, since that was a compromise for the sync to block Servo landing to avoid too much cross-repo backout.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8969665 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Attachment #8969663 -
Flags: review?(core-build-config-reviews)
Comment 10•6 years ago
|
||
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b8420da5cde part 1 - Remove stylo-bindings.zip artifact. r=froydnj https://hg.mozilla.org/integration/autoland/rev/ad24bc2a835e part 2 - Not copy generated binding files into dist. r=emilio
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2b8420da5cde https://hg.mozilla.org/mozilla-central/rev/ad24bc2a835e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•