Closed
Bug 1455691
Opened 6 years ago
Closed 6 years ago
Make transaction id strongly-typed
Categories
(Core :: Graphics: Layers, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1448490 +++ We have a bajillion different uint64_t ids being passed around all over the codebase, and it's very easy to accidentally screw up which one you're passing where. I'd like to introduce a TransactionId struct type that allows us to get better compile-time safety.
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8feb10368dab4de25b628bafb55bc790b95bbc3a
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8969766 [details] Bug 1455691 - Make the transaction id a struct instead of a uint64_t. https://reviewboard.mozilla.org/r/238580/#review244424
Attachment #8969766 -
Flags: review?(matt.woodrow) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1224b46e1392 Make the transaction id a struct instead of a uint64_t. r=mattwoodrow
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1224b46e1392
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•