Closed
Bug 1455692
Opened 7 years ago
Closed 7 years ago
add support for limiting locales in partner repacks
Categories
(Release Engineering :: Release Automation, enhancement)
Release Engineering
Release Automation
Tracking
(firefox62 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(2 files, 1 obsolete file)
2.08 KB,
patch
|
nthomas
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
6.20 KB,
patch
|
nthomas
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
This isn't required for production, but it's super helpful in staging.
Assignee | ||
Comment 1•7 years ago
|
||
Pretty simple! Just skip any locales not in the list, or do all locales if the list is empty.
Attachment #8969755 -
Flags: review?(nthomas)
Assignee | ||
Comment 2•7 years ago
|
||
The mozharness part just lets us passthrough to the partner repack script. The partner transform part gathers all locales found in any partner config, and uses that set as the locales to limit to.
It's notable that this will cause --limit-locale to be passed even for full locale releases, which makes the command line long and kindof ugly. I couldn't come up with an obvious fix this.
This was tested on https://tools.taskcluster.net/groups/BKZiibK9TLmz7A05KolsFA. I did some checks of the candidates dir and dep partner bucket, and I _think_ everything looks correct (but I'm not an expert).
Attachment #8969758 -
Flags: review?(nthomas)
Updated•7 years ago
|
Attachment #8969758 -
Attachment is patch: true
Attachment #8969758 -
Attachment mime type: video/dv → text/plain
Updated•7 years ago
|
Attachment #8969755 -
Flags: review?(nthomas) → review+
Comment 3•7 years ago
|
||
Comment on attachment 8969758 [details] [diff] [review]
add support for limiting locales in mozharness script + transform
I'm not 100% sold on this, but didn't really come up with any great alternatives.
Attachment #8969758 -
Flags: review?(nthomas) → review+
Assignee | ||
Comment 4•7 years ago
|
||
This idea is courtesy of Aki, and it seems to work. In my local task graph diffs, this produces the expected locale limiting when using maple-promote-firefox, and doesn't for mb-promote-firefox.,
Attachment #8969758 -
Attachment is obsolete: true
Attachment #8973287 -
Flags: review?(nthomas)
Comment 5•7 years ago
|
||
Comment on attachment 8973287 [details] [diff] [review]
only limit locales on staging branches
lgtm, thanks!
Attachment #8973287 -
Flags: review?(nthomas) → review+
Pushed by bhearsum@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee395dfab2cc
add support for limiting locales in partner repacks. r=nthomas
Assignee | ||
Updated•7 years ago
|
Attachment #8973287 -
Flags: checked-in+
Assignee | ||
Updated•7 years ago
|
Attachment #8969755 -
Flags: checked-in+
Comment 7•7 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•