Closed Bug 1455749 Opened Last year Closed Last year

Fix caret control when editing text

Categories

(Core :: Disability Access APIs, enhancement)

All
Android
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 4 obsolete files)

For some reason, when an entry is focused and being edited, you can't change the granularity of talkback to characters/words/lines. This makes moving the caret hard.
Attachment #8974478 - Flags: review?(yzenevich)
Attachment #8974478 - Flags: review?(nchen)
Comment on attachment 8974478 [details] [diff] [review]
Advertise nodes as editable and focusable (1/2). r?jchen r?yzen

Review of attachment 8974478 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on java bits
Attachment #8974478 - Flags: review?(nchen) → review+
Comment on attachment 8974478 [details] [diff] [review]
Advertise nodes as editable and focusable (1/2). r?jchen r?yzen

Review of attachment 8974478 [details] [diff] [review]:
-----------------------------------------------------------------

Cool thanks

::: accessible/jsat/EventManager.jsm
@@ +264,5 @@
>               Roles.DOCUMENT,
>               Roles.APPLICATION].includes(acc.role)) {
>            this.contentControl.autoMove(acc);
>         }
> +       this.present(Presentation.focused(acc));

nit: the } above has wrong indentation. Also could you add a new line after if's }
Attachment #8974478 - Flags: review?(yzenevich) → review+
Comment on attachment 8974479 [details] [diff] [review]
Simplify text navigation and remove editstate in AccessFu (2/2). r?yzen

Review of attachment 8974479 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

::: accessible/jsat/AccessFu.jsm
@@ +389,5 @@
>    },
>  
>    moveByGranularity: function moveByGranularity(aDetails) {
>      const GRANULARITY_PARAGRAPH = 8;
>      const GRANULARITY_LINE = 4;

These should be removed?

::: accessible/jsat/ContentControl.jsm
@@ +300,5 @@
>      return true;
>    },
>  
>    handleMoveByGranularity: function cc_handleMoveByGranularity(aMessage) {
> +    let { direction, granularity } = aMessage.json;

Same here, should we start gradually switching to data from json?

@@ +310,3 @@
>  
> +    let pivotGranularity;
> +

nit: no need for new line
Attachment #8974479 - Flags: review?(yzenevich) → review+
(In reply to Yura Zenevich [:yzen] from comment #5)
> ::: accessible/jsat/ContentControl.jsm
> @@ +300,5 @@
> >      return true;
> >    },
> >  
> >    handleMoveByGranularity: function cc_handleMoveByGranularity(aMessage) {
> > +    let { direction, granularity } = aMessage.json;
> 
> Same here, should we start gradually switching to data from json?

I'll spin out a new bug for that.
Attachment #8974478 - Attachment is obsolete: true
Attachment #8974479 - Attachment is obsolete: true
Assignee: nobody → eitan
Keywords: checkin-needed
Needs rebasing.
Keywords: checkin-needed
Attachment #8974819 - Attachment is obsolete: true
Attachment #8974820 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1089dc357a8
Advertise nodes as editable and focusable (1/2). r=jchen,yzen
https://hg.mozilla.org/integration/mozilla-inbound/rev/4345a33a957c
Simplify text navigation and remove editstate in AccessFu (2/2). r=yzen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b1089dc357a8
https://hg.mozilla.org/mozilla-central/rev/4345a33a957c
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.