1455749 - Fix caret control when editing text

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Eitan Isaacson [:eeejay]]

For some reason, when an entry is focused and being edited, you can't change the granularity of talkback to characters/words/lines. This makes moving the caret hard.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Advertise nodes as editable and focusable (1/2). r?jchen r?yzen

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Simplify text navigation and remove editstate in AccessFu (2/2). r?yzen

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8974478 [details] [diff] [review]
Advertise nodes as editable and focusable (1/2). r?jchen r?yzen

Review of attachment 8974478 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on java bits

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8974478 [details] [diff] [review]
Advertise nodes as editable and focusable (1/2). r?jchen r?yzen

Review of attachment 8974478 [details] [diff] [review]:
-----------------------------------------------------------------

Cool thanks

::: accessible/jsat/EventManager.jsm
@@ +264,5 @@
>               Roles.DOCUMENT,
>               Roles.APPLICATION].includes(acc.role)) {
>            this.contentControl.autoMove(acc);
>         }
> +       this.present(Presentation.focused(acc));

nit: the } above has wrong indentation. Also could you add a new line after if's }

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8974479 [details] [diff] [review]
Simplify text navigation and remove editstate in AccessFu (2/2). r?yzen

Review of attachment 8974479 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

::: accessible/jsat/AccessFu.jsm
@@ +389,5 @@
>    },
>  
>    moveByGranularity: function moveByGranularity(aDetails) {
>      const GRANULARITY_PARAGRAPH = 8;
>      const GRANULARITY_LINE = 4;

These should be removed?

::: accessible/jsat/ContentControl.jsm
@@ +300,5 @@
>      return true;
>    },
>  
>    handleMoveByGranularity: function cc_handleMoveByGranularity(aMessage) {
> +    let { direction, granularity } = aMessage.json;

Same here, should we start gradually switching to data from json?

@@ +310,3 @@
>  
> +    let pivotGranularity;
> +

nit: no need for new line

Comment 6

[Eitan Isaacson [:eeejay]]

(In reply to Yura Zenevich [:yzen] from comment #5)
> ::: accessible/jsat/ContentControl.jsm
> @@ +300,5 @@
> >      return true;
> >    },
> >  
> >    handleMoveByGranularity: function cc_handleMoveByGranularity(aMessage) {
> > +    let { direction, granularity } = aMessage.json;
> 
> Same here, should we start gradually switching to data from json?

I'll spin out a new bug for that.

Comment 7

[Eitan Isaacson [:eeejay]]

Attachment: Advertise nodes as editable and focusable (1/2). r=jchen

Comment 8

[Eitan Isaacson [:eeejay]]

Attachment: Simplify text navigation and remove editstate in AccessFu (2/2).

Comment 9

[Ryan VanderMeulen (PTO, back July 27)]

Needs rebasing.

Comment 10

[Eitan Isaacson [:eeejay]]

Attachment: Advertise nodes as editable and focusable (1/2). r=jchen

Comment 11

[Eitan Isaacson [:eeejay]]

Attachment: Simplify text navigation and remove editstate in AccessFu (2/2).

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1089dc357a8
Advertise nodes as editable and focusable (1/2). r=jchen,yzen
https://hg.mozilla.org/integration/mozilla-inbound/rev/4345a33a957c
Simplify text navigation and remove editstate in AccessFu (2/2). r=yzen

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b1089dc357a8
https://hg.mozilla.org/mozilla-central/rev/4345a33a957c