1455788 - Hover events where the source is touch get filtered.

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[Randall Barker [:rbarker]]

This is a recent change from bug 1454081 which filters hover events that are generated by a mouse. It has broken hover in Firefox Reality which currently synthesizes touch events, some of which are hover events.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

P2 b/c I think Randall has a work around.

Comment 2

[Randall Barker [:rbarker]]

I've worked around this right now in Firefox Reality but probably still worth figuring out.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Consolidate a11y MotionEvent handling to the GeckoView. r?jchen

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8971622 [details] [diff] [review]
Consolidate a11y MotionEvent handling to the GeckoView. r?jchen

Review of attachment 8971622 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoView.java
@@ +523,5 @@
> +        if (mSession == null) {
> +            return false;
> +        }
> +
> +        return (SessionAccessibility.Settings.isEnabled() &&

I think the | SessionAccessibility.Settings.isEnabled() | check should go inside `SessionAccessibility.onMotionEvent`

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to Jim Chen [:jchen] [:darchons] from comment #4)
> Comment on attachment 8971622 [details] [diff] [review]
> Consolidate a11y MotionEvent handling to the GeckoView. r?jchen
> 
> Review of attachment 8971622 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> :::
> mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoView.java
> @@ +523,5 @@
> > +        if (mSession == null) {
> > +            return false;
> > +        }
> > +
> > +        return (SessionAccessibility.Settings.isEnabled() &&
> 
> I think the | SessionAccessibility.Settings.isEnabled() | check should go
> inside `SessionAccessibility.onMotionEvent`

Since GeckoSession.getAccessibility is a lazy getter, I was worried we would instantiate the object needlessly on the first motion event. But I guess we do that on window attachment anyway!

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Consolidate a11y MotionEvent handling to the GeckoView.

Should this go in before the freeze? Looks like this isn't a P1, so I will leave this here until next week.

Comment 7

[Eitan Isaacson [:eeejay]]

Attachment: Consolidate a11y MotionEvent handling to the GeckoView.

Rebased.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9f138b851de
Consolidate a11y MotionEvent handling to the GeckoView. r=jchen

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e9f138b851de