Closed Bug 1455795 Opened 2 years ago Closed 2 years ago

`cargo build` fails due to automation configure options

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: terpri, Assigned: terpri)

Details

Attachments

(1 file, 1 obsolete file)

Compiling the Rust js bindings uses an automation build for spidermonkey, which doesn't work when a recent version of glibc is installed. Automation builds set the --enable-stdcxx-compat configure option, causing compilation to fail if glibc symbols with versions over 2.12 are used.
The attached patch changes the Rust build to not set autospider.py's AUTOMATION option at all. If compatibility with old libraries is needed for the Rust bindings, it should also be possible to change the default and configure this somewhere else in the build process, e.g. based on whether the 'dev' or 'release' Cargo profile is being used. Then local builds would work, but release builds would still use the required compatibility options.
Attachment #8969854 - Flags: review?(sphink)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Comment on attachment 8969854 [details] [diff] [review]
Remove the AUTOMATION option from mozjs_sys's build.rs.

Review of attachment 8969854 [details] [diff] [review]:
-----------------------------------------------------------------

Hm... I don't know if anything *really* needs this backwards compatibility stuff for Rust bindings, but just in case, can you also add

  export AUTOMATION=1

to taskcluster/scripts/builder/build-sm-mozjs-crate.sh?
Attachment #8969854 - Flags: review?(sphink) → review+
This option shouldn't be used for local builds (see bug 1294157). Set
the option from the crate's taskcluster script instead, so that it's
used only for automated builds.
(In reply to Steve Fink [:sfink] [:s:] (PTO June 31) from comment #3)
> Comment on attachment 8969854 [details] [diff] [review]
> Remove the AUTOMATION option from mozjs_sys's build.rs.
> 
> Review of attachment 8969854 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Hm... I don't know if anything *really* needs this backwards compatibility
> stuff for Rust bindings, but just in case, can you also add
> 
>   export AUTOMATION=1
> 
> to taskcluster/scripts/builder/build-sm-mozjs-crate.sh?

Good idea, added in the new version.
Attachment #8970764 - Flags: review?(sphink)
Attachment #8970764 - Flags: review?(sphink) → review+
Keywords: checkin-needed
Attachment #8969854 - Attachment is obsolete: true
Assignee: nobody → robin
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/49735826de01
Remove the AUTOMATION option from mozjs_sys's build.rs. r=sfink
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/49735826de01
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.