Closed Bug 1455868 Opened 5 years ago Closed 5 years ago

Permafail toolkit/mozapps/extensions/test/xpcshell/test_signed_langpack.js when Gecko 61 merges to Beta on 2018-04-26

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- verified

People

(Reporter: aryx, Assigned: kmag)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1455868: Expect unsigned langpack install to fail on release builds.
59 bytes, text/x-review-board-request
aswan
: review+
Details 
Regression from bug 1454141.

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eb7c05a2a4cfd295545d947ddc581279beb92dd&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=174930883

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=174930883&repo=try

[task 2018-04-21T11:25:41.022Z] 11:25:40     INFO -  PID 15414 | 1524309940787	addons.xpi	WARN	Add-on langpack-klingon@firefox.mozilla.org is not correctly signed.
[task 2018-04-21T11:25:41.022Z] 11:25:40     INFO -  PID 15414 | 1524309940787	addons.xpi	WARN	Add-on langpack-klingon@firefox.mozilla.org is not correctly signed.
[task 2018-04-21T11:25:41.023Z] 11:25:40     INFO -  PID 15414 | 1524309940788	addons.xpi	WARN	Invalid XPI: signature is required but missing
k 2018-04-21T11:25:41.025Z] 11:25:40     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_signed_langpack.js |  - 4 == 4
[task 2018-04-21T11:25:41.026Z] 11:25:40     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_signed_langpack.js |  - -5 == -5
[task 2018-04-21T11:25:41.026Z] 11:25:40     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_signed_langpack.js |  - null == null
[task 2018-04-21T11:25:41.027Z] 11:25:40     INFO -  PID 15414 | 1524309940791	addons.xpi-utils	DEBUG	XPI Database saved, setting schema version preference to 24
[task 2018-04-21T11:25:41.028Z] 11:25:40     INFO -  "CONSOLE_MESSAGE: (info) 1524309940787	addons.xpi	WARN	Add-on langpack-klingon@firefox.mozilla.org is not correctly signed."
[task 2018-04-21T11:25:41.028Z] 11:25:40     INFO -  "CONSOLE_MESSAGE: (info) 1524309940787	addons.xpi	WARN	Add-on langpack-klingon@firefox.mozilla.org is not correctly signed."
[task 2018-04-21T11:25:41.030Z] 11:25:40     INFO -  "CONSOLE_MESSAGE: (info) 1524309940788	addons.xpi	WARN	Invalid XPI: signature is required but missing"
[task 2018-04-21T11:25:41.031Z] 11:25:40     INFO -  "CONSOLE_MESSAGE: (info) 1524309940791	addons.xpi-utils	DEBUG	XPI Database saved, setting schema version preference to 24"
[task 2018-04-21T11:25:41.031Z] 11:25:40     INFO -  PID 15414 | 1524309940795	addons.xpi	WARN	Add-on langpack-klingon@firefox.mozilla.org is not correctly signed.
[task 2018-04-21T11:25:41.033Z] 11:25:40     INFO -  PID 15414 | 1524309940795	addons.xpi	WARN	Add-on langpack-klingon@firefox.mozilla.org is not correctly signed.
[task 2018-04-21T11:25:41.033Z] 11:25:40     INFO -  PID 15414 | 1524309940796	addons.xpi	WARN	Invalid XPI: signature is required but missing
[task 2018-04-21T11:25:41.034Z] 11:25:40     INFO -  Unexpected exception Error: Expected file to be downloaded for install of /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/data/signing_checks/langpack_unsigned.xpi at resource://testing-common/AddonTestUtils.jsm:1327
[task 2018-04-21T11:25:41.035Z] 11:25:40     INFO -  promiseInstallFile/<@resource://testing-common/AddonTestUtils.jsm:1327:15
[task 2018-04-21T11:25:41.036Z] 11:25:40     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:215:3
[task 2018-04-21T11:25:41.036Z] 11:25:40     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:521:5
[task 2018-04-21T11:25:41.037Z] 11:25:40     INFO -  @-e:1:1

Let the expected value of https://dxr.mozilla.org/mozilla-central/rev/cc0d7de218cb0c260c8ba0cf6637845ad2222f49/toolkit/mozapps/extensions/test/xpcshell/test_signed_langpack.js#51 depend on RELEASE_OR_BETA?
Flags: needinfo?(aswan)
Comment on attachment 8969950 [details]
Bug 1455868: Expect unsigned langpack install to fail on release builds.

https://reviewboard.mozilla.org/r/238728/#review244458
Attachment #8969950 - Flags: review?(aswan) → review+
Flags: needinfo?(aswan)
https://hg.mozilla.org/integration/mozilla-inbound/rev/40e62bd007f76eefabd152b06ed1a9104180e0e9
Bug 1455868: Expect unsigned langpack install to fail on release builds. r=aswan
https://hg.mozilla.org/mozilla-central/rev/40e62bd007f7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee: nobody → kmaglione+bmo
Keywords: regression
You need to log in before you can comment on or make changes to this bug.