Closed Bug 1455965 Opened 2 years ago Closed 2 years ago

Unused strings in browser.dtd - customizeMenu.addToPanel and friends

Categories

(Firefox :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox61 --- wontfix
firefox62 --- fixed

People

(Reporter: Gijs, Assigned: sahith.reddy, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

All of these strings:

<!ENTITY customizeMenu.addToPanel.label "Add to Menu">
<!ENTITY customizeMenu.addToPanel.accesskey "M">
<!ENTITY customizeMenu.moveToToolbar.label "Move to Toolbar">
<!ENTITY customizeMenu.moveToToolbar.accesskey "o">
<!ENTITY customizeMenu.moveToPanel.label "Move to Menu">
<!ENTITY customizeMenu.moveToPanel.accesskey "o">
<!ENTITY customizeMenu.removeFromMenu.label "Remove from Menu">
<!ENTITY customizeMenu.removeFromMenu.accesskey "R">

in browser/locales/en-US/chrome/browser/browser.dtd are unused and can be removed, as far as I can tell.

We should also update the localization note next to moveToToolbar/moveToPanel to remove mention of those items.

We should also update the localization note next to addToOverflowMenu.label to remove the sentence about "these are only used in Photon".
I'd like to work on this bug.
(In reply to absnathanr from comment #1)
> I'd like to work on this bug.

Great! Have you cloned the source tree yet? You can attach a patch or submit it via mozreview, and then we can assign the bug to you.
Flags: needinfo?(absnathanr)
Clearing needinfo since no response, if someone else would like to work this feel free to pick it up.
Flags: needinfo?(absnathanr)
Priority: -- → P5
Hello, I would like to work on this issue. This is my first attempt at open source so sorry for any mistakes.
I am not sure if I did this correctly as I am new to the process but I put a codereview up https://reviewboard.mozilla.org/r/252514/
Comment on attachment 8987241 [details]
Bug 1455965 - Removed obsolete strings

https://reviewboard.mozilla.org/r/252514/#review258998

Looks good to me, thanks!
Attachment #8987241 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/dee91f9d3b3a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Assignee: nobody → sahith.reddy
You need to log in before you can comment on or make changes to this bug.