1455965 - Unused strings in browser.dtd - customizeMenu.addToPanel and friends

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[:Gijs (he/him)]

All of these strings:

<!ENTITY customizeMenu.addToPanel.label "Add to Menu">
<!ENTITY customizeMenu.addToPanel.accesskey "M">
<!ENTITY customizeMenu.moveToToolbar.label "Move to Toolbar">
<!ENTITY customizeMenu.moveToToolbar.accesskey "o">
<!ENTITY customizeMenu.moveToPanel.label "Move to Menu">
<!ENTITY customizeMenu.moveToPanel.accesskey "o">
<!ENTITY customizeMenu.removeFromMenu.label "Remove from Menu">
<!ENTITY customizeMenu.removeFromMenu.accesskey "R">

in browser/locales/en-US/chrome/browser/browser.dtd are unused and can be removed, as far as I can tell.

We should also update the localization note next to moveToToolbar/moveToPanel to remove mention of those items.

We should also update the localization note next to addToOverflowMenu.label to remove the sentence about "these are only used in Photon".

Comment 1

[absnathanr]

I'd like to work on this bug.

Comment 2

[:Gijs (he/him)]

(In reply to absnathanr from comment #1)
> I'd like to work on this bug.

Great! Have you cloned the source tree yet? You can attach a patch or submit it via mozreview, and then we can assign the bug to you.

Comment 3

[Justin Dolske [:Dolske]]

Clearing needinfo since no response, if someone else would like to work this feel free to pick it up.

Comment 4

[sahith.reddy]

Hello, I would like to work on this issue. This is my first attempt at open source so sorry for any mistakes.

Comment 5

[sahith.reddy]

Attachment: Bug 1455965 - Removed obsolete strings

Review commit: https://reviewboard.mozilla.org/r/252514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252514/

Comment 6

[sahith.reddy]

I am not sure if I did this correctly as I am new to the process but I put a codereview up https://reviewboard.mozilla.org/r/252514/

Comment 7

[:Gijs (he/him)]

Comment on attachment 8987241 [details]
Bug 1455965 - Removed obsolete strings

https://reviewboard.mozilla.org/r/252514/#review258998

Looks good to me, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dee91f9d3b3a
Removed obsolete strings r=Gijs

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/dee91f9d3b3a