Closed Bug 1456051 Opened 3 years ago Closed 3 years ago

Convert addon.js, cert.js, and server.js into ES modules

Categories

(Testing :: Marionette, enhancement)

enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(6 files, 1 obsolete file)

No description provided.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attachment #8970099 - Attachment is obsolete: true
Attachment #8970099 - Flags: review?(mjzffr)
Comment on attachment 8970097 [details]
Bug 1456051 - Avoid double-wrapping of UnknownError.

https://reviewboard.mozilla.org/r/238872/#review244634
Attachment #8970097 - Flags: review?(mjzffr) → review+
Comment on attachment 8970098 [details]
Bug 1456051 - Propagate OS errors on addon installation.

https://reviewboard.mozilla.org/r/238874/#review244636
Attachment #8970098 - Flags: review?(mjzffr) → review+
Comment on attachment 8970100 [details]
Bug 1456051 - Make addon.uninstall race safe.

https://reviewboard.mozilla.org/r/238878/#review244640
Attachment #8970100 - Flags: review?(mjzffr) → review+
Comment on attachment 8970102 [details]
Bug 1456051 - Make cert an ES module.

https://reviewboard.mozilla.org/r/238882/#review244644

::: testing/marionette/cert.js:67
(Diff revision 3)
> -};
> +  }
>  
> -/**
> +  /**
> - * Uninstall a TLS certificate service override.
> +   * Uninstall a TLS certificate service override.
> - *
> +   *
> - * After the service has been unregistered, |cert.currentOverride|
> +   * If there no current override installed this function acts as a no-op.

typo: if there is no
Attachment #8970102 - Flags: review?(mjzffr) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59953ad26fcf
Avoid double-wrapping of UnknownError. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/52c5217fc17b
Propagate OS errors on addon installation. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/db7a5dec3809
Make addon.uninstall race safe. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/f0baa9e18c42
Make addon an ES module. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/2746c64ce7f1
Make cert an ES module. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/08b2848c73e1
Make server an ES module. r=maja_zf
You need to log in before you can comment on or make changes to this bug.