Closed
Bug 1456051
Opened 6 years ago
Closed 6 years ago
Convert addon.js, cert.js, and server.js into ES modules
Categories
(Remote Protocol :: Marionette, enhancement)
Remote Protocol
Marionette
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(6 files, 1 obsolete file)
59 bytes,
text/x-review-board-request
|
impossibus
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
impossibus
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
impossibus
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
impossibus
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
impossibus
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
impossibus
:
review+
|
Details |
No description provided.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8970099 -
Attachment is obsolete: true
Attachment #8970099 -
Flags: review?(mjzffr)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 20•6 years ago
|
||
mozreview-review |
Comment on attachment 8970097 [details] Bug 1456051 - Avoid double-wrapping of UnknownError. https://reviewboard.mozilla.org/r/238872/#review244634
Attachment #8970097 -
Flags: review?(mjzffr) → review+
Comment 21•6 years ago
|
||
mozreview-review |
Comment on attachment 8970098 [details] Bug 1456051 - Propagate OS errors on addon installation. https://reviewboard.mozilla.org/r/238874/#review244636
Attachment #8970098 -
Flags: review?(mjzffr) → review+
Comment 22•6 years ago
|
||
mozreview-review |
Comment on attachment 8970100 [details] Bug 1456051 - Make addon.uninstall race safe. https://reviewboard.mozilla.org/r/238878/#review244640
Attachment #8970100 -
Flags: review?(mjzffr) → review+
Comment 23•6 years ago
|
||
mozreview-review |
Comment on attachment 8970101 [details] Bug 1456051 - Make addon an ES module. https://reviewboard.mozilla.org/r/238880/#review244642
Attachment #8970101 -
Flags: review?(mjzffr) → review+
Comment 24•6 years ago
|
||
mozreview-review |
Comment on attachment 8970102 [details] Bug 1456051 - Make cert an ES module. https://reviewboard.mozilla.org/r/238882/#review244644 ::: testing/marionette/cert.js:67 (Diff revision 3) > -}; > + } > > -/** > + /** > - * Uninstall a TLS certificate service override. > + * Uninstall a TLS certificate service override. > - * > + * > - * After the service has been unregistered, |cert.currentOverride| > + * If there no current override installed this function acts as a no-op. typo: if there is no
Attachment #8970102 -
Flags: review?(mjzffr) → review+
Comment 25•6 years ago
|
||
mozreview-review |
Comment on attachment 8970103 [details] Bug 1456051 - Make server an ES module. https://reviewboard.mozilla.org/r/238884/#review244646
Attachment #8970103 -
Flags: review?(mjzffr) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 28•6 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59953ad26fcf Avoid double-wrapping of UnknownError. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/52c5217fc17b Propagate OS errors on addon installation. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/db7a5dec3809 Make addon.uninstall race safe. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/f0baa9e18c42 Make addon an ES module. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/2746c64ce7f1 Make cert an ES module. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/08b2848c73e1 Make server an ES module. r=maja_zf
Comment 29•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/59953ad26fcf https://hg.mozilla.org/mozilla-central/rev/52c5217fc17b https://hg.mozilla.org/mozilla-central/rev/db7a5dec3809 https://hg.mozilla.org/mozilla-central/rev/f0baa9e18c42 https://hg.mozilla.org/mozilla-central/rev/2746c64ce7f1 https://hg.mozilla.org/mozilla-central/rev/08b2848c73e1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•