Closed Bug 1456075 Opened 6 years ago Closed 6 years ago

Remove standalone/launchpad startup code from inspector.js

Categories

(DevTools :: Inspector, enhancement, P3)

61 Branch
enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Launchpad support for the inspector was removed, and as far as I can tell using 

chrome://devtools/content/inspector/inspector.xhtml?type=tab&id=tabId 

no longer works (by default, inspector init calls some methods not implemented in a tab).

I propose to remove the dedicated startup code from inspector.js. This will simplify reworking the tool's initialization in Bug 1455421
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8970119 [details]
Bug 1456075 - Remove standalone inspector initialization code;

https://reviewboard.mozilla.org/r/238920/#review244608

Note that isn't related to launchpad and is mostly broken because of `inspectorExtensionSidebars` and lack of `sourceMapURLService`.

This special init sequence was highlighting how we could start intializing the tools more like a natural web page.
We would need something like this in order to get the tools working OOP.
But as this isn't the production code, it isn't testing and breaks,
so I imagine we could get rid of it until we make some progress on projects requiring such init sequence (launchpad or oop)
Attachment #8970119 - Flags: review?(poirot.alex) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0483916013c8
Remove standalone inspector initialization code;r=ochameau
https://hg.mozilla.org/mozilla-central/rev/0483916013c8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.