1456082 - When opening a new tab, it shows a completely white screen.

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Aditya Dutt]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180419200216

Steps to reproduce:

Open a new tab. (not the one that appears at the start.)


Actual results:

It shows a completely white screen with the title : New Tab

See this : https://i.imgur.com/J4bTUYL.png


Expected results:

It should have showed the normal new tab, which it shows when Firefox starts for the first time. (or while opening a new tab)

Like this : https://i.imgur.com/0kj1utf.png

Comment 1

[Girish Sharma [:Optimizer]]

Can confirm. This is happening since at least 21st April build. Although, I doubt that Firefox build version has anything to do with this since the code is sitting in an addon. Thus, this might be platform/os independent as well - but I can only confirm for Windows 10 x64.

This is the error observed in the browser console - 

Error: storeNames and telemetry are required, called only with storeNames,telemetry view-source:resource://activity-stream/lib/ActivityStreamStorage.jsm:9:13

This is the activity stream version from about:support page - 2018.04.20.1268-306bd7e2

One question - There were automated tests for new tab page to capture these simple failures. Is activity stream going to continue as an addon? Are there plans to add automated tests for an addon code?

Comment 2

[Kate Hudson :k88hudson]

Activity Stream does have automated tests (see https://dxr.mozilla.org/mozilla-central/source/browser/extensions/activity-stream/test), but it seems that they did not catch this particular issue. We will look into adding one.

Comment 3

[Andrei Oprea [:andreio]]

Thanks for reporting this. Just to confirm that I'm looking into the correct failure can you tell me the value of your `browser.newtabpage.activity-stream.feeds.telemetry` pref? Thanks.

Comment 4

[Girish Sharma [:Optimizer]]

(In reply to Andrei Oprea [:andreio] from comment #3)
> Thanks for reporting this. Just to confirm that I'm looking into the correct
> failure can you tell me the value of your
> `browser.newtabpage.activity-stream.feeds.telemetry` pref? Thanks.

It's false

Comment 5

[Girish Sharma [:Optimizer]]

(In reply to Kate Hudson :k88hudson from comment #2)
> Activity Stream does have automated tests (see
> https://dxr.mozilla.org/mozilla-central/source/browser/extensions/activity-
> stream/test), but it seems that they did not catch this particular issue. We
> will look into adding one.

Oh. Thanks for the reply. Wasn't aware that extensions can have automated tests.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4123

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/ff0517ddf74e347a1c37e2ca1efd2b3eca533e27
Fix Bug 1456082 - Storage should not have telemetry be a required argument

Comment 8

[Aditya Dutt]

When will I see this in fixed in Firefox Developer Edition?

Comment 9

[Ed Lee :Mardak]

This change needs to make it to Nightly 61 first. Looks like dev edition builds once a week during the 61 soft code freeze, before 61 is fully in Beta where it switches to builds twice a week.

Comment 10

[Girish Sharma [:Optimizer]]

Exactly how long before this lands in nightly? It has been two days. Is this waiting for AMO review?

Comment 11

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/2c8338ffc0c0

Comment 12

[Stefania]

I reproduced this issue using Firefox 61.0a1 (2018-04-23), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Firefox 62.0a1 (2018-05-09)and Firefox 61.0b3 on Windows 10 x64.