Closed Bug 1456087 Opened 3 years ago Closed 3 years ago

Create tests for devtools.main.exit telemetry event

Categories

(DevTools :: General, enhancement)

57 Branch
enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: miker, Assigned: miker)

References

Details

Attachments

(1 file)

No description provided.
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
OS: Unspecified → All
Hardware: Unspecified → All
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Moving to M1 for splitting off M2 work.
Comment on attachment 8970934 [details]
Bug 1456087 - Create tests for devtools.main.exit telemetry event

https://reviewboard.mozilla.org/r/239694/#review245666

Looks great, one question. Thanks!

::: devtools/client/framework/test/browser_toolbox_telemetry_exit.js:101
(Diff revision 1)
> +  await gDevTools.showToolbox(target, "netmonitor");
> +
> +  await checkResults();
> +});
> +
> +async function checkResults() {

i noticed this same method in the other test pr -- does it make sense to combine these into a util somewhere? with whatever difference being passed in as args?
Attachment #8970934 - Flags: review?(ystartsev) → review+
Comment on attachment 8970934 [details]
Bug 1456087 - Create tests for devtools.main.exit telemetry event

https://reviewboard.mozilla.org/r/239694/#review245776

::: devtools/client/framework/test/browser_toolbox_telemetry_exit.js:101
(Diff revision 1)
> +  await gDevTools.showToolbox(target, "netmonitor");
> +
> +  await checkResults();
> +});
> +
> +async function checkResults() {

We are looking at different fields so we can't really do that... maybe we could if we will be having lots more tests but let's leave it alone for now.
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5af5821aa84c
Create tests for devtools.main.exit telemetry event r=yulia
https://hg.mozilla.org/mozilla-central/rev/5af5821aa84c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.