1456087 - Create tests for devtools.main.exit telemetry event

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1456087 - Create tests for devtools.main.exit telemetry event

Review commit: https://reviewboard.mozilla.org/r/239694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239694/

Comment 2

[:Harald Kirschner :digitarald]

Moving to M1 for splitting off M2 work.

Comment 3

[Yulia Startsev [:yulia]]

Comment on attachment 8970934 [details]
Bug 1456087 - Create tests for devtools.main.exit telemetry event

https://reviewboard.mozilla.org/r/239694/#review245666

Looks great, one question. Thanks!

::: devtools/client/framework/test/browser_toolbox_telemetry_exit.js:101
(Diff revision 1)
> +  await gDevTools.showToolbox(target, "netmonitor");
> +
> +  await checkResults();
> +});
> +
> +async function checkResults() {

i noticed this same method in the other test pr -- does it make sense to combine these into a util somewhere? with whatever difference being passed in as args?

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8970934 [details]
Bug 1456087 - Create tests for devtools.main.exit telemetry event

https://reviewboard.mozilla.org/r/239694/#review245776

::: devtools/client/framework/test/browser_toolbox_telemetry_exit.js:101
(Diff revision 1)
> +  await gDevTools.showToolbox(target, "netmonitor");
> +
> +  await checkResults();
> +});
> +
> +async function checkResults() {

We are looking at different fields so we can't really do that... maybe we could if we will be having lots more tests but let's leave it alone for now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5af5821aa84c
Create tests for devtools.main.exit telemetry event r=yulia

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5af5821aa84c