1456088 - Consider to remove nsIURISetters::SetScheme

Status: NEW

(Core :: Networking, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

SetScheme isn't really safe to use, since it just modifies the uri object but doesn't go through protocol handlers.
So for example DOM's URL implementation needs to be careful to not use that, but explicitly create a new nsIURI (which requires use of main thread).

https://searchfox.org/mozilla-central/rev/fcd5cb3515d0e06592bba42e378f1b9518497e3d/netwerk/base/nsIURIMutator.idl#183

If SetScheme is needed for things like http -> https, better to have explicitly a method doing such change which is safe on any thread.

Comment 1

[Michal Novotny [:michal]]

Valentin, can you take this bug?

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Yes, of course. I forgot to assign it to myself.

Comment 3

[Mahak]

Hey @valentin !
Can I take this up ?
And Can you elaborate this more ?
Thanks :)