Closed
Bug 1456092
Opened 6 years ago
Closed 6 years ago
Communicate that devtools/client/animationinspector will be replaced by devtools/client/inspector/animation
Categories
(DevTools :: Inspector: Animations, enhancement, P3)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
The code under devtools/client/animationinspector is the code for the current animation inspector in DevTools and a new version is under development in devtools/client/inspector/animation. This is being implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1399830 Having both the new and old code side by side without explanation can be confusing so we should indicate our intentions by: - adding a README under devtools/client/animationinspector - maybe rename/move devtools/client/animationinspector
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8970170 [details] Bug 1456092 - Move devtools/client/animationinspector to devtools/client/inspector/animation-old; https://reviewboard.mozilla.org/r/238966/#review244612
Attachment #8970170 -
Flags: review?(pbrosset) → review+
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8970169 [details] Bug 1456092 - Add README to old animation inspector folder; https://reviewboard.mozilla.org/r/238964/#review244614 Thank you very much!
Attachment #8970169 -
Flags: review?(dakatsuka) → review+
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8970170 [details] Bug 1456092 - Move devtools/client/animationinspector to devtools/client/inspector/animation-old; https://reviewboard.mozilla.org/r/238966/#review244618
Attachment #8970170 -
Flags: review?(dakatsuka) → review+
Assignee | ||
Comment 6•6 years ago
|
||
Thank you both for the reviews! Just adding a small changeset to move some references to our test files and we should be good to go Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=bff92545a790cc160c393f8248e87bb834bcd74c
Comment hidden (mozreview-request) |
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8970194 [details] Bug 1456092 - Update animationinspector paths in mochitest-*.runtimes.json; https://reviewboard.mozilla.org/r/239000/#review244638
Attachment #8970194 -
Flags: review?(pbrosset) → review+
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/11731cdc9a54 Add README to old animation inspector folder;r=daisuke https://hg.mozilla.org/integration/autoland/rev/d904f2015324 Move devtools/client/animationinspector to devtools/client/inspector/animation-old;r=daisuke,pbro https://hg.mozilla.org/integration/autoland/rev/d0c991129303 Update animationinspector paths in mochitest-*.runtimes.json;r=pbro
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/11731cdc9a54 https://hg.mozilla.org/mozilla-central/rev/d904f2015324 https://hg.mozilla.org/mozilla-central/rev/d0c991129303
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•