14561 - We don't get the compose window back if smtp returns an error

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Scott MacGregor]

If for some reason sending a message failed and the smtp code returned an error,
we used to bring the original compose window back into existence so the user
wouldn't loose the message.

That's no longer true today. If I return an error code through a OnStopRequest
call into the smtp protocol's url listener, the send delivery listener doesn't
bring the compose window back.

I'm hoping Jean-Francois might know how this works. I tried to look at it but
didn't have much sucess.

What may be a side effect of this...I noticed you can now send a message without
a subject. You used to get prompted about the subject in 5.0. Or so I thought.

Jean-Francois, I'd be happy to try to track down why the compose window doesn't
go back if you know where to start looking. Some of the code may have been
rhp's....

Comment 1

[Jean-Francois Ducarroz]

The problem is due by the fact that we use some positive string ID as error code. Just cleanup the mess and

everything will work fine.



mscott, could you review the fix. Thanks

Comment 2

[Jean-Francois Ducarroz]

Attachment: patch for the fix

Comment 3

[Jean-Francois Ducarroz]

Fix has been reviewd by mscott

Comment 4

[Jean-Francois Ducarroz]

Fixed and checked in (M10 Branch only)

Comment 5

[lchiang]

Are you going to check into the trunk M11 also?

Comment 6

[Jean-Francois Ducarroz]

Yes, I will...

Comment 7

[Jean-Francois Ducarroz]

Fix checked in the trunk (M11).

Comment 8

[esther]

Using build 1999111017 on win and linux and 1999111111 on mac when I try to send
a message without a recipient, I get the correct alert, the compose window is
still up front and when I OK the alert the compose window is still there.  I
believe this bug is for bringing back the compose window when a send fails
because of an alert, if this is fixed.  If this bug is asking for an alert when
there is no Subject, that is not fixed.  I will verify per my belief, if there
should be an alert for no subject, I will log a separate bug.