1456116 - [FrontEnd] Clicking revision date should not load the next page

Status: RESOLVED INCOMPLETE

(developer.mozilla.org Graveyard :: General, defect, P3)

Description

[Schalk Neethling [:espressive]]

Navigate to the revision dashboard
Click on one of the dates under the Revision heading

What happens
------------

The hidden diff table starts to slide open but, you are then sent to a the next page, such as: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/object$revision/1376385 for example


What should happen
-------------------

The next page should only load if JavaScript is disabled. If enabled, the default action should be prevented so that the inline diff can be shown

Comment 1

[Kadir Topal [:atopal]]

I think this works as designed, even if it's not necessarily great design, at least as far as I can tell. If you click a link, the new page will open, if you click anywhere else in that row (for example on the comment text), the diff table will slide out.

Comment 2

[Schalk Neethling [:espressive]]

That is odd for two reasons

1. We should not even trigger the toggle when there is a click on the date then
2. There is an event listener specifically for that link that calls the slideToggle function. Actually, looking at it again with this knowledge. None of the links should trigger the slideToggle effect.

It would be better if there was a clear icon or other form of CTA that a user would click on to show the diff.

If the intent is that it does not slide out at all for the date link, I would say we need to change the interaction so that clicking the links, simply loads the next page. Currently it definitely looks like the functionality is broken.

Comment 3

[Schalk Neethling [:espressive]]

I definitely feel that we need to redo the interaction here. If you do not know about how this is supposed to work, it is unclear, and seems broken.

Comment 4

[Schalk Neethling [:espressive]]

This is the current expected behaviour. We should rethink this at a later stage. Closing for now.