Closed
Bug 1456145
Opened 6 years ago
Closed 6 years ago
Add impression ping for AS router snippets
Categories
(Firefox :: Messaging System, enhancement, P1)
Firefox
Messaging System
Tracking
()
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: k88hudson, Assigned: andreio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
We need an impression ping for AS router templates. It should: - only be sent when the AS router is actually visible - have a new helper method (see https://github.com/mozilla/activity-stream/blob/4d6cf505c48643b4ad8306d9c66c0a3d320a65a5/system-addon/content-src/message-center/message-center-content.jsx#L30) that defines a ping action type (should be something like ${PROVIDER}_impression) - can borrow from code that already exists to track impression pings in AS :nanj can help handle this ping / define what the ping action should be
Reporter | ||
Updated•6 years ago
|
Iteration: 60.4 - Mar 12 → 61.4 - May 7
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → andrei.br92
Updated•6 years ago
|
Priority: -- → P2
Updated•6 years ago
|
Priority: P2 → P1
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/bdf9ca55d3520d143964b44612d54eeb9e663e04 Bug 1456145 - Add impression ping for AS Router https://github.com/mozilla/activity-stream/commit/2f718eb067433c36b68d84727b454b5f6ac3e3be Bug 1456145 - Follow-up on impression pings for AS Router
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 4•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a9f5a8dc2e22
status-firefox61:
--- → fixed
Target Milestone: --- → Firefox 61
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•