Closed Bug 145615 Opened 23 years ago Closed 23 years ago

Should use AString instead of wstring or DOMString in accessibility APIs

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: zhayupeng, Assigned: zhayupeng)

References

Details

Attachments

(1 file, 2 obsolete files)

Use AString
6.79 KB, patch
aaronlev
: review+
jst
: superreview+
Details | Diff | Splinter Review
We should DOMString in nsIAccessibleTable instead of wstring. It's more efficient.
Summary: Shouls use DOMString instead of wstring in nsIAccessibleTable.idl → Should use DOMString instead of wstring in nsIAccessibleTable.idl
Attached patch patch (obsolete) — — Splinter Review
summary is DOMString getColumnDescription and getRowDescription should return DOMString either
What about nsIAccessibleAction.idl, nsIAccessibleText.idl and nsIAccessibleEditableText.idl Can we do all of them in one patch?
Attachment #84227 - Attachment is obsolete: true
Comment on attachment 84228 [details] [diff] [review] patch for all idls in mozilla/accessibility/public who uses wstring r=aaronl
Attachment #84228 - Flags: review+
Attachment #84228 - Attachment description: patch for all idl who use wstring → patch for all idls in mozilla/accessibility/public who uses wstring
Attachment #84228 - Flags: review+
Comment on attachment 84228 [details] [diff] [review] patch for all idls in mozilla/accessibility/public who uses wstring aaronl, seems that we update the attachment at the same time. :) bring back your r=
Attachment #84228 - Flags: review+
Do we really want to tie these API's to _DOM_String? The "DOMString" IDL type is supposed to be for DOM things only (yeah, we have abused that in the past, but now we have better alternatives). I'd say you should use "AString" in stead of "DOMString", they map to the same thing in C++, at least for now. If you have good reasons for using "DOMString" here in stead of using "AString", let me know and I'll sr this change if I afree, if not, do an s/DOMString/AString/g on the diff and I'll sr.
Since AString and DOMString are basically the same, let's use AString since these are not DOM APIs. Changing summary, and requesting new patch.
Summary: Should use DOMString instead of wstring in nsIAccessibleTable.idl → Should use AString instead of wstring or DOMString in accessibility APIs
Attached patch Use AString — — Splinter Review
please r= and sr= Thanks.
Attachment #84228 - Attachment is obsolete: true
Comment on attachment 84376 [details] [diff] [review] Use AString r=aaronl
Attachment #84376 - Flags: review+
Comment on attachment 84376 [details] [diff] [review] Use AString sr=jst
Attachment #84376 - Flags: superreview+
checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Blocks: 136315
-- Looks like all DOMString's are converted to AString's. Marking the bug as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: