Should use AString instead of wstring or DOMString in accessibility APIs

VERIFIED FIXED

Status

()

VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: zhayupeng, Assigned: zhayupeng)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

17 years ago
We should DOMString in nsIAccessibleTable instead of wstring. It's more efficient.

Updated

17 years ago
Summary: Shouls use DOMString instead of wstring in nsIAccessibleTable.idl → Should use DOMString instead of wstring in nsIAccessibleTable.idl
(Assignee)

Comment 1

17 years ago
Created attachment 84227 [details] [diff] [review]
patch

summary is DOMString
getColumnDescription and getRowDescription should return DOMString either

Comment 2

17 years ago
What about nsIAccessibleAction.idl, nsIAccessibleText.idl and
nsIAccessibleEditableText.idl

Can we do all of them in one patch?
(Assignee)

Comment 3

17 years ago
Created attachment 84228 [details] [diff] [review]
patch for all idls in mozilla/accessibility/public who uses wstring
Attachment #84227 - Attachment is obsolete: true

Comment 4

17 years ago
Comment on attachment 84228 [details] [diff] [review]
patch for all idls in mozilla/accessibility/public who uses wstring

r=aaronl
Attachment #84228 - Flags: review+
(Assignee)

Updated

17 years ago
Attachment #84228 - Attachment description: patch for all idl who use wstring → patch for all idls in mozilla/accessibility/public who uses wstring
Attachment #84228 - Flags: review+
(Assignee)

Comment 5

17 years ago
Comment on attachment 84228 [details] [diff] [review]
patch for all idls in mozilla/accessibility/public who uses wstring

aaronl, seems that we update the attachment at the same time. :)
bring back your r=
Attachment #84228 - Flags: review+
Do we really want to tie these API's to _DOM_String? The "DOMString" IDL type is
supposed to be for DOM things only (yeah, we have abused that in the past, but
now we have better alternatives). I'd say you should use "AString" in stead of
"DOMString", they map to the same thing in C++, at least for now. If you have
good reasons for using "DOMString" here in stead of using "AString", let me know
and I'll sr this change if I afree, if not, do an s/DOMString/AString/g on the
diff and I'll sr.

Comment 7

17 years ago
Since AString and DOMString are basically the same, let's use AString since
these are not DOM APIs.

Changing summary, and requesting new patch.
Summary: Should use DOMString instead of wstring in nsIAccessibleTable.idl → Should use AString instead of wstring or DOMString in accessibility APIs
(Assignee)

Comment 8

17 years ago
Created attachment 84376 [details] [diff] [review]
Use AString

please r= and sr=
Thanks.
(Assignee)

Updated

17 years ago
Attachment #84228 - Attachment is obsolete: true

Comment 9

17 years ago
Comment on attachment 84376 [details] [diff] [review]
Use AString

r=aaronl
Attachment #84376 - Flags: review+
Comment on attachment 84376 [details] [diff] [review]
Use AString

sr=jst
Attachment #84376 - Flags: superreview+
(Assignee)

Comment 11

17 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Updated

17 years ago
Blocks: 136315

Comment 12

17 years ago
-- Looks like all DOMString's are converted to AString's. Marking the bug as
verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.