Closed Bug 1456160 Opened Last year Closed Last year

[wpt-sync] Sync PR 10582 - Fix some layout tests that calls createPseudo

Categories

(Core :: DOM: Animation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10582 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10582
Details from upstream follow.

Xida Chen <xidachen@chromium.org> wrote:
>  Fix some layout tests that calls createPseudo
>  
>  In my previous CL I changed createPseudo function to getPseudoElement
>  without updating some of the callers. This CL fixes that.
>  
>  Bug: None
>  Change-Id: I7a1f4bcc83736234e8bec2f16656cd72c39fd51d
>  Reviewed-on: https://chromium-review.googlesource.com/1023974
>  WPT-Export-Revision: c54d9f63c43b7575901d9320f42463e7d3cfb6a6
Component: web-platform-tests → DOM: Animation
Product: Testing → Core
Ran 3 tests and 2077 subtests
OK     : 3
PASS   : 2069
FAIL   : 8

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/web-animations/animation-model/animation-types/accumulation-per-property.html
    content: ""a"" onto ""b"": FAIL
    content: ""b"" onto ""a"": FAIL
/web-animations/animation-model/animation-types/addition-per-property.html
    content: ""a"" onto ""b"": FAIL
    content: ""b"" onto ""a"": FAIL
/web-animations/animation-model/animation-types/interpolation-per-property.html
    content uses discrete animation when animating between ""a"" and ""b"" with effect easing: FAIL
    content uses discrete animation when animating between ""a"" and ""b"" with keyframe easing: FAIL
    content uses discrete animation when animating between ""a"" and ""b"" with linear easing: FAIL
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/51cffe1745dd
[wpt PR 10582] - Fix some layout tests that calls createPseudo, a=testonly
Didn't this commit fix these failures that were introduced in bug 1455186?  This commit should have reverted the failure annotation, but it seems not.  What happened?  James?

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e3ae5728187#l1.10
Flags: needinfo?(james)
Honestly, I don't know enough about the specifics of the test to answer that. It seems like this change introduced some new failures but didn't fix any existing ones (not sure why there were so many try pushes here, but the first one seems like the right one to look at).
Flags: needinfo?(james)
Thank you, James.   It seems to me that there happens some gaps that we don't properly update expectation files (I assume each try push is independent from others).  Anyway I will take a look these tests once they got merged into m-c.
https://hg.mozilla.org/mozilla-central/rev/51cffe1745dd
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
That metadata was fixed in bug 1457798.  I don't quite understand how it works.

https://hg.mozilla.org/mozilla-central/rev/9299ab4a5235#l54.2
You need to log in before you can comment on or make changes to this bug.