1456183 - Unable to build Firefox: gio/gunixfdlist.h not found.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Nicolas B. Pierron [:nbp]]

Bug 1411589 introduced a use of gio/gunixfdlist.h header, which is not pulled by pkg-config on NixOS [1].
I double checked that gio-unix-2.0 is part of the dependencies provided to the build environment.

// Configure log.
checking for gtk+-3.0 >= 3.4.0 gtk+-unix-print-3.0 glib-2.0 gobject-2.0 ... yes
checking MOZ_GTK3_CFLAGS...
  -I<...>/glib-2.56.0-dev/include/glib-2.0
  -I<...>/glib-2.56.0/lib/glib-2.0/include
  -I<...>/cairo-1.14.10-dev/include/cairo
  -I<...>/freetype-2.7.1-dev/include/freetype2
  -I<...>/freetype-2.7.1-dev/include
  -I<...>/pango-1.40.14-dev/include/pango-1.0
  -I<...>/gdk-pixbuf-2.36.7-dev/include/gdk-pixbuf-2.0
  -I<...>/atk-2.28.1-dev/include/atk-1.0
  -I<...>/gtk+3-3.22.29-dev/include/gtk-3.0/unix-print
  -I<...>/gtk+3-3.22.29-dev/include/gtk-3.0
checking MOZ_GTK3_LIBS...
  -L<...>/glib-2.56.0/lib
  -L<...>/cairo-1.14.10/lib
  -L<...>/pango-1.40.14/lib
  -L<...>/gdk-pixbuf-2.36.7/lib
  -L<...>/atk-2.28.1/lib
  -L<...>/gtk+3-3.22.29/lib
  … -lgio-2.0 …
checking for gtk+-2.0 >= 2.18.0 gtk+-unix-print-2.0 glib-2.0 >= 2.22 gobject-2.0 gdk-x11-2.0... yes
checking MOZ_GTK2_CFLAGS...
  -I<...>/glib-2.56.0-dev/include/glib-2.0
  -I<...>/glib-2.56.0/lib/glib-2.0/include
  -I<...>/gtk+-2.24.32-dev/include/gtk-2.0
  -I<...>/gtk+-2.24.32-dev/include/gtk-unix-print-2.0
  -I<...>/gtk+-2.24.32-dev/include/gtk-2.0
  -I<...>/gtk+-2.24.32/lib/gtk-2.0/include
  -I<...>/cairo-1.14.10-dev/include/cairo
  -I<...>/freetype-2.7.1-dev/include/freetype2
  -I<...>/freetype-2.7.1-dev/include
  -I<...>/fontconfig-2.12.1-dev/include
  -I<...>/expat-2.2.5-dev/include
  -I<...>/freetype-2.7.1-dev/include/freetype2
  -I<...>/pango-1.40.14-dev/include/pango-1.0
  -I<...>/gdk-pixbuf-2.36.7-dev/include/gdk-pixbuf-2.0
  -I<...>/atk-2.28.1-dev/include/atk-1.0
checking MOZ_GTK2_LIBS...
  … -lgio-2.0 …

// Testing manually.
$ pkg-config --cflags gio-unix-2.0
  -I<...>/glib-2.56.0-dev/include/gio-unix-2.0/
  -I<...>/glib-2.56.0-dev/include/glib-2.0
  -I<...>/glib-2.56.0/lib/glib-2.0/include

Should we add gio-unix-2.0 as part of the list of phg-config packages in old-configure.in ?

[1] https://github.com/mozilla/nixpkgs-mozilla/blob/master/firefox-overlay.nix#L139

Comment 1

[Nicolas B. Pierron [:nbp]]

One option would be to add gio-unix in the list of packages of old-configure.in, another option would be to remove these extra headers and use some wrapper function provided by the packages that we already use.

Which way would you recommend?

Comment 2

[Jan Horak [:jhorak]]

The gio/gunixfdlist.h is required for the GUnixFDList struct. This structure is converted to GVariant (required for Dbus interface) quite easily. I can try to change the code to avoid using GUnixFDList, but I rather prefer the first option. Could you please make a patch for it since I don't have access to the affected system?

Comment 3

[Nicolas B. Pierron [:nbp]]

Attachment: Add gio-unix as part of the list of GTK dependencies.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb155557e0deb821c876d6ea1d1e3ea185112912

Comment 4

[Jan Horak [:jhorak]]

Comment on attachment 8971175 [details] [diff] [review]
Add gio-unix as part of the list of GTK dependencies.

Sorry, I can't do review for this part, let's ask Mike.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eac1b2073bf4
Add gio-unix as part of the list of GTK dependencies. r=glandium

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/eac1b2073bf4