Closed
Bug 1456192
Opened 6 years ago
Closed 6 years ago
mark some IPC functions as MOZ_NEVER_INLINE
Categories
(Core :: IPC, enhancement)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: froydnj, Assigned: away)
References
Details
Attachments
(2 files)
1.05 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
1.36 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
As MSVC's PGO inliner has gotten somewhat more aggressive with recent updates and to just rein in code bloat generally. The patches I am going to attach shortly were originally written by David Major, and I am going to land them as such, with my review on them.
Reporter | ||
Comment 1•6 years ago
|
||
This function is just pure bloat when it gets inlined, and it will disappear on non-Nightly builds anyway. Make it MOZ_NEVER_INLINE so our size statistics on Nightly are somewhat more reflective of our size statistics on Release.
Attachment #8970259 -
Flags: review+
Reporter | ||
Comment 2•6 years ago
|
||
MSVC's PGO inliner thinks these functions are hot enough to be inlined, but they're really not, and inlining them bloats xul.dll quite a bit.
Attachment #8970260 -
Flags: review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e893040e197f make Pickle::ReadSentinel MOZ_NEVER_INLINE; r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5f5d37a32e make {Read,Write}IPDLParam MOZ_NEVER_INLINE; r=froydnj
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e893040e197f https://hg.mozilla.org/mozilla-central/rev/5f5f5d37a32e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Assignee: nobody → dmajor
Comment 5•6 years ago
|
||
Did we see an installer size reduction from this push?
Flags: needinfo?(igoldan)
Comment 6•6 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5) > Did we see an installer size reduction from this push? Yes, there was some something visible. Unfortunately, another regression landed soon after this bug and basically cancelled the wins here. I caught the regression in bug 1457405.
Flags: needinfo?(igoldan)
You need to log in
before you can comment on or make changes to this bug.
Description
•