1456192 - mark some IPC functions as MOZ_NEVER_INLINE

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Nathan Froyd [:froydnj]]

As MSVC's PGO inliner has gotten somewhat more aggressive with recent updates and to just rein in code bloat generally.

The patches I am going to attach shortly were originally written by David Major, and I am going to land them as such, with my review on them.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: make Pickle::ReadSentinel MOZ_NEVER_INLINE

This function is just pure bloat when it gets inlined, and it will
disappear on non-Nightly builds anyway.  Make it MOZ_NEVER_INLINE so our
size statistics on Nightly are somewhat more reflective of our size
statistics on Release.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: make {Read,Write}IPDLParam MOZ_NEVER_INLINE

MSVC's PGO inliner thinks these functions are hot enough to be inlined,
but they're really not, and inlining them bloats xul.dll quite a bit.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e893040e197f
make Pickle::ReadSentinel MOZ_NEVER_INLINE; r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5f5d37a32e
make {Read,Write}IPDLParam MOZ_NEVER_INLINE; r=froydnj

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e893040e197f
https://hg.mozilla.org/mozilla-central/rev/5f5f5d37a32e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Did we see an installer size reduction from this push?

Comment 6

[Ionuț Goldan [:igoldan]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> Did we see an installer size reduction from this push?

Yes, there was some something visible. Unfortunately, another regression landed soon after this bug and basically cancelled the wins here. I caught the regression in bug 1457405.