1456197 - Asynchronously notify users when a landing fails

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement, P2)

Description

[Steven MacLeod [:smacleod]]

It is possible transplant can fail to land something which Lando has queued. When this happens visiting the Lando page will display that the landing has failed, but there is no asynchronous notification (email, bug, etc) to the lander. MozReview + Autoland initially had this problem and it was a big pain.

We should add some notification mechanism to Lando so that landers know a landing has failed.

Comment 2

[Piotr Zalewa [:zalun]]

Just a note that in the duplicate bug it was suggested to flag for needinfo on bugzilla.

Comment 4

[Māris Fogels [:mars] (please needinfo)]

Attachment: tests: make the test suite pass when run outside of docker (bug 1456197)

Comment 5

[Māris Fogels [:mars] (please needinfo)]

Attachment: config: clean up app configuration (bug 1456197)

Make the webhead-only env config variables optional so Ops doesn't need
to set unneeded vars for non-webhead processes in production.  Make the
configure_app() function handle env vars consistently.

Depends on D12691

Comment 6

[Māris Fogels [:mars] (please needinfo)]

Attachment: transplants: integrate Celery (bug 1456197)

Integrate Celery with lando-api.  Add a dummy task to Celery that logs
landing failures so we can see how the framework functions once deployed
.

Depends on D12692

Comment 7

[Māris Fogels [:mars] (please needinfo)]

Attachment: transplants: monitor Celery tasks with Datadog (bug 1456197)

Depends on D12693

Comment 9

[Māris Fogels [:mars] (please needinfo)]

Attachment: transplants: send email when a transplant job fails (bug 1456197)

Use the Flask-mail library to send an email notification to the user
when their branch fails to land.

Comment 10

[Māris Fogels [:mars] (please needinfo)]

Ops says this feature will be delayed until the end of Q1 because this service's email infrastructure is migrating to GCP. Ops will be in touch when the new email system is in place and ready for testing.

Comment 11

[Steven MacLeod [:smacleod]]

This has landed and is working in the dev environment now. Production deployment should happen this weekend.