14562 - minor tweak to Makefile.in for editor/txmgr/src and editor/txtsvc/src

Status: CLOSED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Colin Blake]

I found two places where we link xpcom from dist/lib instead
of the usual dist/bin. Yeah, I know, the libraries
are in both places, but everywhere else we link from
dist/bin, so for consistency... (plus I play a trick on the
VMS so files, and I only play that trick in the dist/bin
directory, so I really do need this checkin)

Comment 1

[Colin Blake]

Index: txmgr/src/Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/editor/txmgr/src/Makefile.in,v
retrieving revision 1.10
diff -u -r1.10 Makefile.in
--- Makefile.in 1999/09/09 03:34:15     1.10
+++ Makefile.in 1999/09/22 11:42:43
@@ -36,7 +36,7 @@
                $(NULL)

 EXTRA_DSO_LDOPTS = \
-               -L$(DIST)/lib \
+               -L$(DIST)/bin \
                -lxpcom \
                $(NULL)

Index: txtsvc/src/Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/editor/txtsvc/src/Makefile.in,v
retrieving revision 1.4
diff -u -r1.4 Makefile.in
--- Makefile.in 1999/09/09 03:34:18     1.4
+++ Makefile.in 1999/09/22 11:42:43
@@ -35,7 +35,7 @@
                $(NULL)

 EXTRA_DSO_LDOPTS = \
-               -L$(DIST)/lib \
+               -L$(DIST)/bin \
                -lxpcom \
                $(NULL)

Comment 2

[Brian Ostrom]

I will approve these changes on one condition: don't delete the -L$(DIST)/lib
line, but rather move it _after_ the -L$(DIST)/bin line.  That way, static-only
builds will still be able to find libxpcom if needed.

Comment 3

[Colin Blake]

While I don't mind doing what you ask Brian, I beleive there are many
other places where only the bin directory is used in a -L statement
to locate xpcom.

Comment 4

[Colin Blake]

Checked in as requested by Brian, that is, with dist/bin added BEFORE
dist/lib.

Comment 5

[Colin Blake]

Verified in M10 build. Closing.