Closed Bug 1456254 Opened 2 years ago Closed 2 years ago

onNewSession() is broken

Categories

(GeckoView :: General, defect, P1)

59 Branch
defect

Tracking

(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox59 wontfix, firefox60 wontfix, firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox59 --- wontfix
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

Details

Attachments

(1 file)

onNewSession() is correctly called, but nothing is loaded into a returned session. With e10s.
Assignee: nobody → snorp
Comment on attachment 8971058 [details]
Bug 1456254 - Correctly set nextTabParentId in GeckoView

https://reviewboard.mozilla.org/r/239800/#review245728

::: mobile/android/modules/geckoview/GeckoViewNavigation.jsm:99
(Diff revision 1)
>    // Message manager event handler.
>    receiveMessage(aMsg) {
>      debug `receiveMessage: ${aMsg.name}`;
>    }
>  
> -  waitAndSetOpener(aSessionId, aOpener) {
> +  waitAndSetupWindow(aSessionId, { opener, nextTabParentId }) {

I'm not sure whether unpacked arguments should have the a-prefix.
Attachment #8971058 - Flags: review?(esawin) → review+
(In reply to Eugen Sawin [:esawin] from comment #2)
> Comment on attachment 8971058 [details]
> Bug 1456254 - Correctly set nextTabParentId in GeckoView
> 
> https://reviewboard.mozilla.org/r/239800/#review245728
> 
> ::: mobile/android/modules/geckoview/GeckoViewNavigation.jsm:99
> (Diff revision 1)
> >    // Message manager event handler.
> >    receiveMessage(aMsg) {
> >      debug `receiveMessage: ${aMsg.name}`;
> >    }
> >  
> > -  waitAndSetOpener(aSessionId, aOpener) {
> > +  waitAndSetupWindow(aSessionId, { opener, nextTabParentId }) {
> 
> I'm not sure whether unpacked arguments should have the a-prefix.

I think not, since they're properties of an object -- but I'm also against the 'a' prefix in general.
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #3)
> I think not, since they're properties of an object -- but I'm also against
> the 'a' prefix in general.

Yeah, I've grown tired of it in JS code, too. We should consider switching away over time.
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de23cd2fcc4a
Correctly set nextTabParentId in GeckoView r=esawin
https://hg.mozilla.org/mozilla-central/rev/de23cd2fcc4a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox for Android → GeckoView
Version: Firefox 59 → 59 Branch
Target Milestone: Firefox 61 → mozilla61
You need to log in before you can comment on or make changes to this bug.