Closed Bug 1456263 Opened 2 years ago Closed 5 months ago

ChannelMergerNode constructor should throw errors

Categories

(Core :: Web Audio, defect, P3)

57 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: toy.raymond, Assigned: padenot)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Steps to reproduce:

This is very closely related to 1443224.  The constructor for ChannelMergerNode should also not allow you to set channelCount and channelCountMode  to invalid values.  It currently does:

c = new AudioContext()
n = new ChannelMergerNode(c, {channelCount: 3, channelCountMode: "max"});
n.channelCount;
n.channelCountMode;


channelCount is set to 3, and channelCountMode is set to "max".
Component: Untriaged → Web Audio
Product: Firefox → Core
Rank: 15
Priority: -- → P2
See Also: → 1443224
Assignee: nobody → padenot
Priority: P2 → P3
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88e3307169f7
Throw appropriate errors in the ChannelMergerNode ctor. r=karlt
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Documentation complete:

Let me know if you'd like to see anything else. Thanks!

You need to log in before you can comment on or make changes to this bug.