Closed Bug 1456296 Opened 2 years ago Closed 2 years ago

Move IdentifierName parsing into a separate function from TSS::getTokenInternal

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Simplifies some control flow by eliminating some gotos, gets rid of some locals in getTokenInternal.
Attached patch PatchSplinter Review
Attachment #8970373 - Flags: review?(arai.unmht)
Comment on attachment 8970373 [details] [diff] [review]
Patch

Review of attachment 8970373 [details] [diff] [review]:
-----------------------------------------------------------------

Nice simplification :)
Attachment #8970373 - Flags: review?(arai.unmht) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3010f9088dc7
Move IdentifierName parsing into a separate function from TSS::getTokenInternal to simplify some control flow.  r=arai
https://hg.mozilla.org/mozilla-central/rev/3010f9088dc7
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.