Closed Bug 1456364 Opened 6 years ago Closed 6 years ago

Use uint8_t for CSS property flags

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(5 files)

After bug 1455576, we would have only 6 CSS property flags. It makes no sense to use uint32_t for the flags anymore. We can just have them use uint8_t so that the flag table is also more compact.
Comment on attachment 8970470 [details]
Bug 1456364 part 1 - Reduce dependencies to nsCSSProps.h.

https://reviewboard.mozilla.org/r/239236/#review244920
Attachment #8970470 - Flags: review?(emilio) → review+
Comment on attachment 8970471 [details]
Bug 1456364 part 2 - Remove PropertyParseType.

https://reviewboard.mozilla.org/r/239238/#review244922
Attachment #8970471 - Flags: review?(emilio) → review+
Comment on attachment 8970472 [details]
Bug 1456364 part 3 - Remove flags from nsCSSPropList.h.

https://reviewboard.mozilla.org/r/239240/#review244926

::: commit-message-1d803:4
(Diff revision 1)
> +Bug 1456364 part 3 - Remove flags from nsCSSPropList.h. r?emilio
> +
> +Some assertions are also removed because they are no longer necessary.
> +The script generating the flags guarantees those assertions are hold.

nit: s/are hold/hold
Attachment #8970472 - Flags: review?(emilio) → review+
Comment on attachment 8970473 [details]
Bug 1456364 part 4 - Convert CSS_PROPERTY_* flags to a typed enum flags.

https://reviewboard.mozilla.org/r/239242/#review244964

Sorry for the lag here. r=me, thanks!
Attachment #8970473 - Flags: review?(emilio) → review+
No worries. It is not blocked by you anyway :)
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab1472823e8a
part 1 - Reduce dependencies to nsCSSProps.h. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d919bbe7440c
part 2 - Remove PropertyParseType. r=emilio
https://hg.mozilla.org/integration/autoland/rev/bc0aa5224d91
part 3 - Remove flags from nsCSSPropList.h. r=emilio
https://hg.mozilla.org/integration/autoland/rev/020151240bb8
part 4 - Convert CSS_PROPERTY_* flags to a typed enum flags. r=emilio
Backed out for failing build bustages at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/AnimationEffectReadOnlyBinding.h:35:3

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=020151240bb8d98378faea9b34e9576e495d3175

Failure log: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=020151240bb8d98378faea9b34e9576e495d3175

Backout: https://hg.mozilla.org/integration/autoland/rev/2146e75c9861a6096655a037b1ccd70aefe7b70e
Flags: needinfo?(xidorn+moz)
emilio said he can help having a look at this.
Flags: needinfo?(emilio)
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a747384172af
part 0 - Add a missing X11UndefineNone.h. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/46b7f067934a
part 1 - Reduce dependencies to nsCSSProps.h. r=emilio
https://hg.mozilla.org/integration/mozilla-inbound/rev/344b5a9033f0
part 2 - Remove PropertyParseType. r=emilio
https://hg.mozilla.org/integration/mozilla-inbound/rev/eff909bc29a7
part 3 - Remove flags from nsCSSPropList.h. r=emilio
https://hg.mozilla.org/integration/mozilla-inbound/rev/47db02b5cdc9
part 4 - Convert CSS_PROPERTY_* flags to a typed enum flags. r=emilio
Flags: needinfo?(xidorn+moz)
You need to log in before you can comment on or make changes to this bug.