Closed Bug 1456377 Opened 2 years ago Closed 2 years ago

Move all composition event handlers into TextEditor from EditorBase

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

(Keywords: inputmethod)

Attachments

(1 file)

Currently, EditorBase implements most of composition event handlers. However, eCompositionChange event handler which is the main handler needs to access TextEditor's members.  Therefore, only it is in TextEditor.

Instead, all composition event handlers should be in TextEditor, then, it becomes easier to read what editor does for a set of composition events.
Keywords: inputmethod
OS: Unspecified → All
Hardware: Unspecified → All
Comment on attachment 8970442 [details]
Bug 1456377 - Move composition event handlers from EditorBase to TextEditor

https://reviewboard.mozilla.org/r/239204/#review244928
Attachment #8970442 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/77e5d42d7d55
Move composition event handlers from EditorBase to TextEditor r=m_kato
https://hg.mozilla.org/mozilla-central/rev/77e5d42d7d55
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.