Closed Bug 1456382 Opened Last year Closed Last year

Convert mAdminThreadId check to MOZ_RELEASE_ASSERT

Categories

(Core :: Gecko Profiler, enhancement)

ARM64
Unspecified
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: m_kato, Assigned: jseward)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1450185 +++

> Please remove that change.  Clearly this still needs to be fixed, otherwise
> the warnings will break your build (I assume).  Given that (1) it's unlikely
> that people will use the profiler in debug builds, (2) failure of these
> assertions is likely to lead to deadlocking or crashing in the profiler, and
> (3) they don't occur on high-frequency paths, I propose that a better fix is
> to convert them to MOZ_RELEASE_ASSERTs.  We should do that in a separate bug.
Proposed patch.
Attachment #8970664 - Flags: review?(n.nethercote)
Attachment #8970664 - Flags: review?(n.nethercote) → review+
Pushed by jseward@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4538b8ecce8
LUL: Convert mAdminThreadId check to MOZ_RELEASE_ASSERT.  r=njn.
https://hg.mozilla.org/mozilla-central/rev/a4538b8ecce8
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee: nobody → jseward
You need to log in before you can comment on or make changes to this bug.