1456417 - addIceCandidate without sdpMLineIndex incorrectly assumes sdpMLineIndex = 0

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Philipp Hancke [:fippo]]

steps to reproduce:
1. run https://jsfiddle.net/1xxf4pnh/
2. observe this exception in the console: 
DOMException: Mismatch between mid and level - "sdparta_1" is not the mid for level 0; "sdparta_0" is
 sdparta_1

The fiddle removes the sdpMLineIndex and it looks like this gets interpreted as 0. Passing 0 does not help either.

The spec seems to prefer sdpMid over sdpMLineIndex:
https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addicecandidate
but the Firefox behaviour suggests it is the other way round.

Not a regression, happens in 52/ESR too as far as I can see.

Comment 1

[Philipp Hancke [:fippo]]

err... passing "null" does not help either. Passing "0" would be wrong.

Comment 2

[Byron Campen [:bwc]]

Yeah, I think the spec used to mandate this behavior?

Comment 3

[Philipp Hancke [:fippo]]

The spec may have switched opinion on what is the preferred thing but interpreting nothing as 0 would be wrong too :-)

Comment 4

[Nils Ohlmeier [:drno]]

Attachment: Bug 1456417: ignore MLineIndex 0 when comparing with MID. r?bwc

Comment 5

[Nils Ohlmeier [:drno]]

Attachment: Bug 1456417: made MLineIndex nullable. r?bwc

Comment 6

[Nils Ohlmeier [:drno]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2a85f23ecf290d5f95830dec43c03bc1160134e

Comment 7

[Nils Ohlmeier [:drno]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=27514d01b0d9562988c33be18eaf3be54d293802

Comment 8

[Nils Ohlmeier [:drno]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c27b86c0c5e4572acdb89726f538523ef3315647

Comment 9

[Nils Ohlmeier [:drno]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b3ce5dc22d28bf1c446e195342dd01da00b8259

Comment 10

[Nils Ohlmeier [:drno]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=64b9db423e70e574565742fb796072ff2934715c

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c729de094ae
made MLineIndex nullable. r=bwc,smaug

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14047 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/9c729de094ae

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged