Closed
Bug 1456417
Opened 6 years ago
Closed 6 years ago
addIceCandidate without sdpMLineIndex incorrectly assumes sdpMLineIndex = 0
Categories
(Core :: WebRTC: Signaling, defect, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: fippo, Assigned: drno)
Details
Attachments
(1 file, 1 obsolete file)
steps to reproduce: 1. run https://jsfiddle.net/1xxf4pnh/ 2. observe this exception in the console: DOMException: Mismatch between mid and level - "sdparta_1" is not the mid for level 0; "sdparta_0" is sdparta_1 The fiddle removes the sdpMLineIndex and it looks like this gets interpreted as 0. Passing 0 does not help either. The spec seems to prefer sdpMid over sdpMLineIndex: https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addicecandidate but the Firefox behaviour suggests it is the other way round. Not a regression, happens in 52/ESR too as far as I can see.
Reporter | ||
Comment 1•6 years ago
|
||
err... passing "null" does not help either. Passing "0" would be wrong.
Comment 2•6 years ago
|
||
Yeah, I think the spec used to mandate this behavior?
Reporter | ||
Comment 3•6 years ago
|
||
The spec may have switched opinion on what is the preferred thing but interpreting nothing as 0 would be wrong too :-)
Updated•6 years ago
|
Rank: 19
Priority: -- → P2
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Updated•6 years ago
|
Attachment #9022097 -
Attachment is obsolete: true
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2a85f23ecf290d5f95830dec43c03bc1160134e
Assignee: nobody → drno
Assignee | ||
Comment 7•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=27514d01b0d9562988c33be18eaf3be54d293802
Assignee | ||
Comment 8•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c27b86c0c5e4572acdb89726f538523ef3315647
Assignee | ||
Comment 9•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b3ce5dc22d28bf1c446e195342dd01da00b8259
Assignee | ||
Comment 10•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=64b9db423e70e574565742fb796072ff2934715c
Comment 11•6 years ago
|
||
Pushed by nohlmeier@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c729de094ae made MLineIndex nullable. r=bwc,smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14047 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9c729de094ae
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Upstream PR merged
You need to log in
before you can comment on or make changes to this bug.
Description
•